Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Gates #1179

Closed
wzdev-ci opened this issue Dec 12, 2009 · 32 comments
Closed

Gates #1179

wzdev-ci opened this issue Dec 12, 2009 · 32 comments

Comments

@wzdev-ci
Copy link
Contributor

keyword_gates resolution_fixed type_patch (an actual patch, not a request for one) | by Per


This experimental patch implements gates. It is currently a proof of concept, but it does work. Sort of. Placeholder gate graphics by Mysteryem.

Gates are implemented as a kind of wall that lowers itself into the ground once a friendly (currently same player) unit attempts to cross it. There is currently not corner version of gates. They open/close individually, but all connected gates should probably open/close as one. They should not close when units are standing on top of them (oops!). No idea when they should appear in tech tree - currently at the same time as hardcrete wall.


Issue migrated from trac:1179 at 2022-04-15 20:12:28 -0700

@wzdev-ci
Copy link
Contributor Author

Per uploaded file gate1.diff (21.4 KiB)

Experimental gate patch. Not for production use. May eat your kitten. Warranty void if read.

@wzdev-ci
Copy link
Contributor Author

BlueMaxima commented


May eat your kitten? ROFL.

Sounds good though.

@wzdev-ci
Copy link
Contributor Author

stiv commented


Just played with this a little bit. Cool feature!

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 4, 2010

Per uploaded file gates3.diff (19.1 KiB)

New version with general improvements. Now does not close when droid is on top. Only code changes included. Need new model that is rotated the same way as walls.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 4, 2010

Per uploaded file gatedata.diff (3.4 KiB)

Sample gate data for testing, reuses existing wall model. Stealth walls!

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 4, 2010

Per commented


I meant stealth gates.

@wzdev-ci
Copy link
Contributor Author

Per commented


(In [9854]) Add backend support for gates using new REF_GATE structure type. See #1179 for more info.

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented


(In Warzone2100/warzone2100@9632b1b) Add backend support for gates using new REF_GATE structure type. See #1179 for more info.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9854 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Per uploaded file gates.wz (28.4 KiB)

Actually working stealth gates mod

@wzdev-ci
Copy link
Contributor Author

KukY commented


lol, they change colours.

@wzdev-ci
Copy link
Contributor Author

Per commented


What? Screenshot, please.

@wzdev-ci
Copy link
Contributor Author

MaNGusT commented


What type of animation does it use? What do I need to do to get my model to open a gate? or is it still harcoded and doesn't use event-driven animation?

@wzdev-ci
Copy link
Contributor Author

Per commented


It is a new hardcoded animation, although I wrote in such a way that it should be easy to generalize in the future. If the model has the type "GATE", then it will lower itself into the ground once a friendly unit tries to pass it, then raise itself later.

@wzdev-ci
Copy link
Contributor Author

MaNGusT commented


I've found a bug. When it lowers itself, it also lowers its baseplate model :(

Also, pathfind works very bad with gates. Units don't know that a gate is a "door", they think that it is a wall. Only when gate is opened, units see that they can pass through. :/

@wzdev-ci
Copy link
Contributor Author

Per commented


I did not think about the base plate. Will fix.

The path finding should work for your own (and I think allied) units, and I tested that before I committed. How do you tell that it is not working?

@wzdev-ci
Copy link
Contributor Author

MaNGusT commented


sorry, I've tested path find a bit more and then I see that it works properly.

@wzdev-ci
Copy link
Contributor Author

Per commented


(In [10407]) Add gates to the game. Model by Mysteryem. May have to be re-balanced a bit. Feedback welcome. See #1179 for more info.

@wzdev-ci
Copy link
Contributor Author

Per commented


MaNGusT - I do not see how a gate could be drawn with a base plate at all with the current code. Do you have a model I can test with?

@wzdev-ci
Copy link
Contributor Author

Per commented


One last thing that needs fixing before this ticket can be closed - the open/close animation is not adapted to the logic/graphic separation, and needs to use the new graphical interpolation functions to avoid the appearance of jerkiness.

@wzdev-ci
Copy link
Contributor Author

Berg commented


don't know if this is related but i had several trucks selected and went to click on gate icon in build menu the cursor stayed a target like when you direct units to a position.
anyway this is what i had in console after crash

info |10:07:07: [clearPlayer] R.I.P. Blue (5). quietly is true
info |10:07:07: [clearPlayer] R.I.P. Green (6). quietly is true
info |10:07:07: [clearPlayer] R.I.P. Cyan (7). quietly is true
error |10:31:02: [buildStructure] Player 0 (Human): is building A0HardcreteMk1Gate at (73, 78) but found A0HardcreteMk1Wall already at (73, 78)
error |10:31:02: [droidUpdateBuild] Trying to update a construction, but no target!
error |10:31:02: [droidUpdateBuild] Assert in Warzone: droid.c:1070 (psDroid->psTarget != NULL), last script event: 'N/A'
warzone2100: droid.c:1070: droidUpdateBuild: Assertion `psDroid->psTarget != ((void *)0)' failed.
Saved dump file to '/tmp/warzone2100.gdmp-M3tiat'
If you create a bugreport regarding this crash, please include this file.
Aborted

thats just the end of the console output where error was i think

@wzdev-ci
Copy link
Contributor Author

Berg commented


crashdump total
http://pastebin.com/c9ckV2vZ

@wzdev-ci
Copy link
Contributor Author

MaNGusT uploaded file gateh.wz (152.1 KiB)

gates with baseplate

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 22, 2010

MaNGusT commented


Replying to Warzone2100/old-trac-import#1179 (comment:12):

MaNGusT - I do not see how a gate could be drawn with a base plate at all with the current code. Do you have a model I can test with?
Grab it. ;-)
To see baseplate I've added some parameters to the "structures.txt"

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented


(In Warzone2100/warzone2100@f88bf76) Add gates to the game. Model by Mysteryem. May have to be re-balanced a bit. Feedback welcome. See #1179 for more info.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@10407 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

icefire uploaded file netgate.jpg (203.2 KiB)

Seems to be some issues on the state of the gates over netplay
netgate.jpg

@wzdev-ci
Copy link
Contributor Author

Buginator commented


adding myself to ticket.

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented


In Warzone2100/warzone2100@9632b1b:

#CommitTicketReference repository="" revision="9632b1bf5026ad79a3f87dc797920f0906970abb"
Add backend support for gates using new REF_GATE structure type. See #1179 for more info.


git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9854 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented


In Warzone2100/warzone2100@f88bf76:

#CommitTicketReference repository="" revision="f88bf760006753a2bc84808bddaee27908e2f294"
Add gates to the game. Model by Mysteryem. May have to be re-balanced a bit. Feedback welcome. See #1179 for more info.


git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@10407 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Per changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Per changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx changed milestone from 3.0 to unspecified

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx commented


Milestone 3.0 deleted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant