Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Show true fog of war #1289

Closed
wzdev-ci opened this issue Dec 30, 2009 · 24 comments
Closed

Show true fog of war #1289

wzdev-ci opened this issue Dec 30, 2009 · 24 comments

Comments

@wzdev-ci
Copy link
Contributor

keyword_visibility resolution_fixed type_patch (an actual patch, not a request for one) | by Per


This patch adds map display of true fog of war to the game. This is the same as what you see when you previously held in the 'z' button.


Issue migrated from trac:1289 at 2022-04-15 20:20:25 -0700

@wzdev-ci
Copy link
Contributor Author

Per uploaded file sensorvis1.diff (8.6 KiB)

@wzdev-ci
Copy link
Contributor Author

Per uploaded file sensorvis2.diff (9.2 KiB)

Fix bug that left visibility remain in areas where units had died.

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Interesting. I didn't see any obvious problems, subjective performamce was a bit lower.

@wzdev-ci
Copy link
Contributor Author

Zarel changed type from defect to enhancement

@wzdev-ci
Copy link
Contributor Author

Zarel commented


cough

@wzdev-ci
Copy link
Contributor Author

Per uploaded file sensorvis3.diff (10.1 KiB)

Added support for allied vision.

@wzdev-ci
Copy link
Contributor Author

Per uploaded file sensorvis4.diff (10.8 KiB)

Also show fog of war in radar minimap. Add some more helpful comments to code.

@wzdev-ci
Copy link
Contributor Author

Per changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Per set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

Per commented


(In [8900]) Add map and radar minimap display of true fog of war to the game. This is the same
as what you see when you previously held in the 'z' button. That is, you see where
you have sensor coverage. Implemented using reference counting on each tile that is
unreferenced using a stored tile cache on each game object. Closes #1289

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


The visual impression is kind of hectic, unsettled, when units move. Smoother transitions might be nice, maybe with the radius increased by half a tile or something to offset the delayed "uncovering".

@wzdev-ci
Copy link
Contributor Author

Per commented


I was thinking of perhaps using the same system as when exploring tiles. Then darkness is slowly lifted instead of suddenly disappearing. However, it requires some reworking and re-purposing of that code, which is rather ugly.

@wzdev-ci
Copy link
Contributor Author

Zarel changed status from closed to reopened

@wzdev-ci
Copy link
Contributor Author

Zarel changed resolution from fixed to ``

@wzdev-ci
Copy link
Contributor Author

Zarel commented


Backport to 2.3?

@wzdev-ci
Copy link
Contributor Author

Zarel commented


I rather like the idea of hectic, unsettled, when units move. It's very useful to get instant updates of vision information.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 1, 2010

cybersphinx uploaded file 0001-Backport-visibility-changes-r8900-to-2.3.patch (11.8 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 1, 2010

cybersphinx commented


Replying to Warzone2100/old-trac-import#1289 (comment:7):

I rather like the idea of hectic, unsettled, when units move. It's very useful to get instant updates of vision information.

Have you tried current trunk with and without the patch in #1296?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 1, 2010

Zarel commented


Yeah. I prefer it without. StarCraft does it the same way (instant vision update). I guess I'm used to it...

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 1, 2010

Terminator commented


Is it possibe to make it togglable ? On the same button for exemple 'z'.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 2, 2010

Per commented


An argument in favour of smooth transitions is consistency, since it is used for exploration already.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 2, 2010

Per changed status from reopened to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 2, 2010

Per changed resolution from `` to fixed

@wzdev-ci wzdev-ci closed this as completed Jan 2, 2010
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2010

Ai_Tak commented


Fog of war only shows in the radar minimap if it is set to terrain, not hight or terrain+hight.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant