Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Occasional crashes when trying to host #1326

Closed
wzdev-ci opened this issue Jan 3, 2010 · 13 comments
Closed

Occasional crashes when trying to host #1326

wzdev-ci opened this issue Jan 3, 2010 · 13 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Jan 3, 2010

type_bug | by cybersphinx


Happens in both 2.3b5 and 2.3 branch. Try to host a network game, sometimes it crashes.


Issue migrated from trac:1326 at 2022-04-15 20:23:01 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2010

cybersphinx uploaded file warzone2100.gdmp-p6I6Uy (28.3 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2010

cybersphinx uploaded file warzone2100.gdmp-ouIPbh (26.7 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2010

Giel commented


Strange..., especially considering that all those values at netplay.c:664 have already been evaluated previously on line 650, except for fds, but that's a local variable.

Thus I'm not at all sure what's going on there. Perhaps a bugged FD_SET (shudders)?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 4, 2010

Per uploaded file strangefunc.diff (0.5 KiB)

That function looks rather odd. This patch makes it less so.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 4, 2010

cybersphinx commented


I tried to reproduce this now, and it didn't fail even once... maybe it was some wrong object file compiled in (though that shouldn't happen), this was after a distclean. Or could it be some server-side problem?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 4, 2010

Giel commented


@per: feel free to commit (both trunk and 2.3)

Replying to Warzone2100/old-trac-import#1326 (comment:2):

I tried to reproduce this now, and it didn't fail even once... maybe it was some wrong object file compiled in (though that shouldn't happen), this was after a distclean. Or could it be some server-side problem?

I don't care if it's a server side problem: the client shouldn't crash as a result...

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 5, 2010

cybersphinx commented


Replying to Warzone2100/old-trac-import#1326 (comment:3):

I don't care if it's a server side problem: the client shouldn't crash as a result...
The question was: Can it be a server side problem? If not, miscompilation gets more likely.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 9, 2010

Zarel commented


Considering many people using self-compiled versions of Warzone on several different operating systems have gotten this exact crash, I doubt it's miscompilation.

Per's patch, while a good idea to commit, couldn't possibly have anything to do with this crash, either: In any situation where Per's patch would make a difference, the game would freeze in the while loop before it could crash where it does.

@wzdev-ci
Copy link
Contributor Author

Buginator changed status from new to pending

@wzdev-ci
Copy link
Contributor Author

Buginator commented


All these patches have died in the HD crash...

@wzdev-ci
Copy link
Contributor Author

Buginator commented


(and the crash dumps)

@wzdev-ci
Copy link
Contributor Author

trac-robot changed status from pending to closed

@wzdev-ci
Copy link
Contributor Author

trac-robot commented


This ticket was closed automatically by the system. It was previously set to a Pending status and hasn't been updated within 7 days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant