Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Crash when saving with proximity display list out of sync with proximity message list #1443

Closed
wzdev-ci opened this issue Jan 20, 2010 · 13 comments
Closed

Crash when saving with proximity display list out of sync with proximity message list #1443

wzdev-ci opened this issue Jan 20, 2010 · 13 comments
Labels
blocker closed component: Engine: other
Milestone
2.3.0

Comments

@wzdev-ci
Copy link
Contributor

keyword_messages_blips resolution_fixed type_bug | by Ai_Tak

This happened while I was making a saved game to report the missing oil indicators, it crashed without making the *.es file and half the files in the sub-directory. I saved before seeing any messed up oil (right after skirmish setup) and had no trouble. Same stderr.txt as in #1430.

stderr.txt:

error |11:26:59: [writeMessageFile] Save message; proximity display not found for message
error |11:26:59: [writeMessageFile] Assert in Warzone: ../../../src/game.c:10655 (psProx != ((void *)0)), last script event: 'N/A'

warzone2100.RPT:
http://pastebin.com/f2c5d3969

Issue migrated from trac:1443 at 2022-04-15 20:55:55 -0700
@wzdev-ci
Copy link
Contributor Author

Per changed status from new to assigned

@wzdev-ci
Copy link
Contributor Author

Per changed component from other to Engine: other

@wzdev-ci
Copy link
Contributor Author

Per changed title from Assert while saving (psProx != ((void *)0)) to Crash when saving with proximity display list out of sync with proximity message list

@wzdev-ci
Copy link
Contributor Author

Per set owner to Per

@wzdev-ci
Copy link
Contributor Author

Per changed keywords from `` to messages blips

@wzdev-ci
Copy link
Contributor Author

Per commented

See also #1442 and #1441 that is the same issue. Fix will be added shortly.

@wzdev-ci
Copy link
Contributor Author

Per commented

This patch fixes the problem with proximity message list and display list going out of sync due to too few proximity buttons allowed at the same time (20), by increasing the limit to 10000. I found an ID range that should be available. It also makes sure that all players get the messages they should (for switching between players), and make a real fix the beacon seen by other players problem by storing but not displaying proximity messages for other players (reverting wrong fix of this problem in #1250).

@wzdev-ci
Copy link
Contributor Author

Per commented

Well, I will add the patch when trac works again :-(

I can add that the patch also removes addOilResourceProximities() which probably never worked as advertised, because it is run before vision is added, and checks if iterated objects are visible before doing anything. It is in any superfluous since visibility functions will add the blips on map load.

@wzdev-ci
Copy link
Contributor Author

Per commented

Patch uploaded to http://pastebin.ca/1760845 for now.

@wzdev-ci
Copy link
Contributor Author

Zarel changed priority from major to blocker

@wzdev-ci
Copy link
Contributor Author

Per changed status from assigned to closed

@wzdev-ci
Copy link
Contributor Author

Per set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

Zarel commented

Fixed in [9382]/[9383]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocker closed component: Engine: other
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@wzdev-ci