Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Remove duplicate points #1582

Closed
wzdev-ci opened this issue Feb 13, 2010 · 12 comments
Closed

Remove duplicate points #1582

wzdev-ci opened this issue Feb 13, 2010 · 12 comments
Labels
closed component: Engine: Graphics normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by Per

This patch uses [9790] to remove duplicate points in all PIE files in trunk. This removes 5878 points. This also removes the need for a duplicate point remover in the PIE loader in the game, which is almost the only place where we have a max points limit. The points remover will also stop working properly when we start using floating point points, so we can just as well start making artists aware that duplicate points are no longer ok.

Issue migrated from trac:1582 at 2022-04-15 21:05:47 -0700
@wzdev-ci
Copy link
Contributor Author

Per uploaded file load.diff (2.0 KiB)

Remove loader points limit and duplicate remover

@wzdev-ci
Copy link
Contributor Author

Per commented

Instead of attaching the almost 1mb size patch, I just paste the command used to create it:

find data/ -iname \*.pie ! -name \.svn -execdir simplipie {} +

@wzdev-ci
Copy link
Contributor Author

Per commented

(In [9792]) Remove 5878 duplicate points in PIE files. See #1582 Reviewed by Safety0ff.

@wzdev-ci
Copy link
Contributor Author

Per changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Per set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

Per commented

(In [9793]) Remove duplicate points removal in PIE loader. Closes #1582 Reviewed by Safety0ff

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented

(In Warzone2100/warzone2100@7b7aca3) Remove 5878 duplicate points in PIE files. See #1582 Reviewed by Safety0ff.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9792 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented

(In Warzone2100/warzone2100@d254e6a) Remove duplicate points removal in PIE loader. Closes #1582 Reviewed by Safety0ff

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9793 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented

In Warzone2100/warzone2100@7b7aca3:

#CommitTicketReference repository="" revision="7b7aca3ce08277c33fdbf965c02e18a77e3aae62"
Remove 5878 duplicate points in PIE files. See #1582 Reviewed by Safety0ff.


git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9792 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented

In Warzone2100/warzone2100@d254e6a:

#CommitTicketReference repository="" revision="d254e6a3396bbfb439e2f34471b760f0c6870c7b"
Remove duplicate points removal in PIE loader. Closes #1582 Reviewed by Safety0ff


git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@9793 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx changed milestone from 3.0 to unspecified

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx commented

Milestone 3.0 deleted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: Graphics normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci