Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Command Relay Center research text invalid #1661

Closed
wzdev-ci opened this issue Mar 6, 2010 · 12 comments
Closed

Command Relay Center research text invalid #1661

wzdev-ci opened this issue Mar 6, 2010 · 12 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Mar 6, 2010

resolution_fixed type_bug | by medhefgo


The Command Relay Center research text says that it allows to control up to five commanders. But you neither have to build it to create commanders nor does it impose a limit on commanders.


Issue migrated from trac:1661 at 2022-04-15 21:11:41 -0700

@wzdev-ci
Copy link
Contributor Author

alfred007 commented


Fixed by Berserk Cyborg with commit 64c1b8cd4b2ea1101cfa23fcd6012c57becf312a.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented


Partially, but this is still a valid bug.

Campaign and multiplayer impose a limit of 10 command units (rules.js), which is simple enough.

Now players must build a command relay to unlock the command turret research. Yet, a player can demolish the command relay and continue manufacturing command units without it.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg uploaded file 0001-Enforce-commander-production-limits-if-no-command-re.patch (4.7 KiB)

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg uploaded file 0002-Fix-Command-Relay-research-text.patch (1.4 KiB)

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented


BTW, first patch is completely optional. Makes it mandatory to have a built command relay to manufacture commanders (acts like command unit limits have been reached if not).

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg committed [7]


In Warzone2100/warzone2100@7d0a911:

#CommitTicketReference repository="" revision="7d0a91180b36a0a75efefaeb94fdcf4a3d7a3832"
Enforce commander production limits if no command relay is built.

Refs ticket 1661.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented


In Warzone2100/warzone2100@e69654e:

#CommitTicketReference repository="" revision="e69654ebeb4f27039d406ca0cc93af8febb3d15a"
Fix Command-Relay research text.

Players can control ten commanders with the current limits.

Closes ticket 1661.

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> commented


In Warzone2100/warzone2100@c165d8c:

#CommitTicketReference repository="" revision="c165d8c1d233b1c3051c21b19aaba669d9cd32e2"
Change console messages for commander limits

Commander units cannot be produced
* without a Command Relay Center
* when owning no less than 10 commanders

More precise console messages distinguish between these causes.

Refs #1661
Fixes #327
Fixes #329

Co-authored-by: spikebike <spikebike@users.noreply.github.com>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant