Terminator uploaded file netplay-0303_202025.log (99.2 KiB)

Terminator uploaded file stderr.txt (3.6 KiB)

Buginator changed status from new to pending

Buginator commented

Terminator, you sure this was beta 12?

Do you recall if people dropped / left before you actually went into the game or not?

Any screenshots?

Terminator commented

I'm 100% sure that this is beta12, as for dropped players, well, one players has been dropped but his buildings & units were left on the map, like he is in very long lag, he wasn't refreshing, well that was not quit perfect game.

Terminator changed status from pending to new

Terminator uploaded file wz2100_Sk-New_TeamWar-T1_shot_001.png (1955.8 KiB)

Buginator commented

[10482] dumps the weapon info in logs to look what is going on.
(dunno why refs #1740 didn't work)

Buginator changed priority from major to critical

Safety0ff uploaded file netplay-0305_155310.log (11.5 KiB)

Safety0ff uploaded file templateAI-Sk-team_waterwar-T1_161222.txt (41.2 KiB)

Safety0ff uploaded file template_03-Sk-team_waterwar-T1_161222.txt (2.6 KiB)

Safety0ff uploaded file template_02-Sk-team_waterwar-T1_161222.txt (2.6 KiB)

Safety0ff uploaded file template_02-Sk-team_waterwar-T1_161222.2.txt (2.6 KiB)

Safety0ff uploaded file template_04-Sk-team_waterwar-T1_161222.txt (3.0 KiB)

Safety0ff uploaded file template_05-Sk-team_waterwar-T1_161222.txt (3.4 KiB)

Safety0ff uploaded file template_06-Sk-team_waterwar-T1_161222.txt (3.1 KiB)

Safety0ff uploaded file template_07-Sk-team_waterwar-T1_161222.txt (2.6 KiB)

Safety0ff uploaded file template_01-Sk-team_waterwar-T1_161222.txt (2.6 KiB)

Safety0ff uploaded file template_00-Sk-team_waterwar-T1_161222.txt (3.2 KiB)

Safety0ff commented

From memory, these players definitely had "legs"

• Black (p7) Human
• Cyan (p?) Human

Buginator commented

Replying to Warzone2100/old-trac-import#1740 (comment:5):

From memory, these players definitely had "legs"

• Black (p7) Human
• Cyan (p?) Human

SafetyOff, did you do anything special to see this? Any steps to reproduce?

So far, the logs look correct, on my quick glance. (sorry, but I am pressed for time, and am leaving in about 2 mins).

icefire uploaded file 8playerDaltBugReport.zip (11.3 KiB)

8 player game, Dalton, player 2, had the legs bug

icefire uploaded file 8cRevolutionBugReport.zip (10.3 KiB)

Forget the player number, Revolution was having the glitch

Daltx commented

Logs from two games only one netplay log for some reason but added leg files from both games. http://www.weebly.com/uploads/3/3/5/4/3354771/logs_-_legs1.zip

Safety0ff commented

It seems that [9606] has a big effect on the borg legs.

We did a few tests with the following changes and the players with the patched version did not see "legs."

Safety0ff changed operating_system which not transferred by tractive

Safety0ff uploaded file legs_cause_outline.diff (1.2 KiB)

Safety0ff commented

Whoops, I didn't mean [9606], I meant [9679].

Safety0ff commented

And [9677] for 2.3.
( If only I could edit my messages rather than ping'ing people everytime I make a correction.)

Safety0ff uploaded file dirty_hack.diff (0.8 KiB)

Safety0ff commented

I used the "dirty hack" above to test another game and I did not see legs ( though it may be premature, and might need more testing.)

Netplay log

not loading droid's weapons for this player (0). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (1). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (2). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (3). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (4). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (5). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (6). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (7). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (8). line: 0, AI:yes 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (0). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (1). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (2). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (3). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (4). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (5). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (6). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
Added droid's weapons for this player. (7). line: 51, AI:no 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010
not loading droid's weapons for this player (8). (did not have template or duplicate) line: 215, AI:yes 	: 0 	(Sync) 	Thu Apr  8 10:09:46 2010

Safety0ff uploaded file UNTESTED_DRAFT.diff (2.6 KiB)

this should force ai template's weapons to get loaded.

Crymson commented

I thought only some templates are for AIs and others only for humans?
This stuff is giving me a headache. We don't really have any documentation what is going on or how it should behave.

Per uploaded file legfix2.diff (1.8 KiB)

How about this?

Crymson commented

Per, your patch don't apply. O_o

Safety0ff commented

You'd have to make sure the arrays don't get overflowed (look at dirty_hack.diff.)

I also think the debugging statements should be edited to make more sense in light of these changes.

Crymson commented

Replying to [comment:22 Safety0ff]:

You'd have to make sure the arrays don't get overflowed (look at dirty_hack.diff.)

I also think the debugging statements should be edited to make more sense in light of these changes.

What do you mean? Per's patch don't apply at all.
Also, it seems this only happens on 8p games? We have tried some 4p game, and never saw the issue.

Safety0ff commented

Replying to [comment:23 Crymson]:

What do you mean? Per's patch don't apply at all.
What do you mean by "don't apply" ? Do you mean you cannot apply the patch or do you mean that it is not relevant? Or do you mean it doesn't fix the issue?

Note that it will only make the client with the patch not see "legs," other clients still might see your 'borgs as "legs."

Replying to [comment:23 Crymson]:

Also, it seems this only happens on 8p games? We have tried some 4p game, and never saw the issue.
I might not be very clear when I express myself, but I tried to explain why it happens (and in which cases it will happen.) Check comments 16, 17 and 18.

Anyways, yes, it seems to be the case (though if you have reports of it happening on maps with less than 8 players, then please post the reports in the 12a thread.)

Per, once you're happy with your patch and tests show that it works, I think it can be committed so that we can put out a 12b to double check that there are no more "legs."

Crymson commented

Replying to [comment:24 Safety0ff]:

Replying to [comment:23 Crymson]:

What do you mean? Per's patch don't apply at all.
What do you mean by "don't apply" ? Do you mean you cannot apply the patch or do you mean that it is not relevant? Or do you mean it doesn't fix the issue?

I tried to apply it to 2.3 and it says patch don't match. I then tried trunk, and it patched it.

Note that it will only make the client with the patch not see "legs," other clients still might see your 'borgs as "legs."

I take it you mean everyone needs the patch in order not to see the legs? If so, then yeah, I knew that.

Replying to [comment:23 Crymson]:

Also, it seems this only happens on 8p games? We have tried some 4p game, and never saw the issue.
I might not be very clear when I express myself, but I tried to explain why it happens (and in which cases it will happen.) Check comments 16, 17 and 18.

Anyways, yes, it seems to be the case (though if you have reports of it happening on maps with less than 8 players, then please post the reports in the 12a thread.)

Per, once you're happy with your patch and tests show that it works, I think it can be committed so that we can put out a 12b to double check that there are no more "legs."

I am trying to find a way to test the patch, but it isn't very clear what we need to do like it was in this ticket, http://developer.wz2100.net/ticket/1687

Safety0ff commented

Replying to [comment:25 Crymson]:

I tried to apply it to 2.3 and it says patch don't match. I then tried trunk, and it patched it.
That's an easy fix (make the changes manually if you don't want to wait.)
I take it you mean everyone needs the patch in order not to see the legs? If so, then yeah, I knew that.
Once you have the patch you shouldn't see legs, others will most likely see legs (even your cyborgs.)
I am trying to find a way to test the patch, but it isn't very clear what we need to do like it was in this ticket, http://developer.wz2100.net/ticket/1687
Look at comment:14 ( though the no quits from the lobby is not relevant,) instructions in ticket #1687 won't work ( that test case was fixed.)

Crymson commented

I know this isn't 8p, but this is what I get in a 4p game.
before, ```
not loading droid's weapons for this player (0). (did not have template or duplicate) line: 0, AI:no : 0 (Sync) Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (1). (did not have template or duplicate) line: 0, AI:no : 0 (Sync) Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (2). (did not have template or duplicate) line: 0, AI:no : 0 (Sync) Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (3). line: 0, AI:yes : 0 (Sync) Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (0). line: 51, AI:no : 0 (Sync) Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (1). line: 51, AI:no : 0 (Sync) Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (2). line: 51, AI:no : 0 (Sync) Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (3). (did not have template or duplicate) line: 215, AI:yes : 0 (Sync) Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (4). (did not have template or duplicate) line: 215, AI:yes : 0 (Sync) Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (5). (did not have template or duplicate) line: 215, AI:yes : 0 (Sync) Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (6). (did not have template or duplicate) line: 215, AI:yes : 0 (Sync) Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (7). (did not have template or duplicate) line: 215, AI:yes : 0 (Sync) Fri Apr 09 12:26:05 2010

after,

not loading droid's weapons for this player (0). (did not have template or duplicate) line: 0, AI:no : 0 (Sync) Fri Apr 09 12:43:58 2010
not loading droid's weapons for this player (1). (did not have template or duplicate) line: 0, AI:no : 0 (Sync) Fri Apr 09 12:43:58 2010
not loading droid's weapons for this player (2). (did not have template or duplicate) line: 0, AI:no : 0 (Sync) Fri Apr 09 12:43:58 2010
Added droid's weapons for this player. (8). line: 0, AI:yes : 0 (Sync) Fri Apr 09 12:43:58 2010
Added droid's weapons for this player. (0). line: 51, AI:no : 0 (Sync) Fri Apr 09 12:43:58 2010
Added droid's weapons for this player. (1). line: 51, AI:no : 0 (Sync) Fri Apr 09 12:43:58 2010
Added droid's weapons for this player. (2). line: 51, AI:no : 0 (Sync) Fri Apr 09 12:43:58 2010

Crymson commented

Damn, screwed up the before. Redoing, since I can't edit it.

Before,

not loading droid's weapons for this player (0). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (1). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (2). (did not have template or duplicate) line: 0, AI:no 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (3). line: 0, AI:yes 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (0). line: 51, AI:no 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (1). line: 51, AI:no 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
Added droid's weapons for this player. (2). line: 51, AI:no 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (3). (did not have template or duplicate) line: 215, AI:yes 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (4). (did not have template or duplicate) line: 215, AI:yes 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (5). (did not have template or duplicate) line: 215, AI:yes 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (6). (did not have template or duplicate) line: 215, AI:yes 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010
not loading droid's weapons for this player (7). (did not have template or duplicate) line: 215, AI:yes 	: 0 	(Sync) 	Fri Apr 09 12:26:05 2010

Safety0ff commented

So?

Was there anything wrong in the game itself?

Crymson commented

Replying to [comment:29 Safety0ff]:

So?

Was there anything wrong in the game itself?

Was wondering if that output is correct?

Safety0ff commented

Well, just from comparing with my output above, I think it might be missing a line at the bottom:

not loading droid's weapons for this player (8). (did not have template or duplicate) line: 215, AI:yes 	: 0 	(Sync)

See comment:22, change the arrays at the beginning to [MAX_PLAYERS+1] and post back if there are any changes.

Crymson commented

Looks like I missed the +1 in the for loop.

It shows this now,

not loading droid's weapons for this player (0). (did not have template or duplicate) line: 0, AI:no  : 0  (Sync)  Fri Apr 09 16:15:33 2010
not loading droid's weapons for this player (1). (did not have template or duplicate) line: 0, AI:no  : 0  (Sync)  Fri Apr 09 16:15:33 2010
not loading droid's weapons for this player (2). (did not have template or duplicate) line: 0, AI:no  : 0  (Sync)  Fri Apr 09 16:15:33 2010
Added droid's weapons for this player. (8). line: 0, AI:yes  : 0  (Sync)  Fri Apr 09 16:15:33 2010
Added droid's weapons for this player. (0). line: 51, AI:no  : 0  (Sync)  Fri Apr 09 16:15:33 2010
Added droid's weapons for this player. (1). line: 51, AI:no  : 0  (Sync)  Fri Apr 09 16:15:33 2010
Added droid's weapons for this player. (2). line: 51, AI:no  : 0  (Sync)  Fri Apr 09 16:15:33 2010
not loading droid's weapons for this player (8). (did not have template or duplicate) line: 215, AI:yes  : 0  (Sync)  Fri Apr 09 16:15:33 2010

Safety0ff commented

Replying to [comment:32 Crymson]:

Looks like I missed the +1 in the for loop.
If you missed it in the loop it should not have reached 8 in your first 'after' log. Do you mean the array? ( feel free to post a diff of what you have.)

Crymson commented

I used

for (i = 0; i <= MAX_PLAYERS; i++)

instead of

for (i = 0; i < MAX_PLAYERS+1; i++)

Safety0ff commented

Those two statements iterate through the same range.

Safety0ff commented

Replying to [comment:22 Safety0ff]:

You'd have to make sure the arrays don't get overflowed (look at dirty_hack.diff.)

I also think the debugging statements should be edited to make more sense in light of these changes.
We could just remove those debugging statements introduced in [10482], especially if this is the end of the "legs" bug !!!

Safety0ff uploaded file fixlegs3.diff (3.5 KiB)

I made some time and put this together.

Safety0ff commented

We tested this once with the test setup described above, all clients could see all cyborgs regularly.

Per changed status from new to closed

Per set resolution to fixed

Per commented

(In [10526]) Make sure template weapons are properly initialized for static templates even if
all player slots are filled with human players. This should fix #1740

Per commented

(In [10527]) 2.3: Make sure template weapons are properly initialized for static templates even if all player
slots are filled with human players. This should fix #1740 Patch by me and SafetyOff.

Git SVN Gateway <gateway@...> commented

(In Warzone2100/warzone2100@2628d7d) Make sure template weapons are properly initialized for static templates even if
all player slots are filled with human players. This should fix #1740

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@10526 4a71c877-e1ca-e34f-864e-861f7616d084

Git SVN Gateway <gateway@...> commented

In Warzone2100/warzone2100@2628d7d:

#CommitTicketReference repository="" revision="2628d7dac79d14ad1af1d122a6c24c2115621d4e"
Make sure template weapons are properly initialized for static templates even if
all player slots are filled with human players. This should fix #1740


git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@10526 4a71c877-e1ca-e34f-864e-861f7616d084