Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Don't blur the radar when it's fixed #1923

Closed
wzdev-ci opened this issue Jun 15, 2010 · 16 comments
Closed

Don't blur the radar when it's fixed #1923

wzdev-ci opened this issue Jun 15, 2010 · 16 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by cybersphinx


This is the patch I accidentally committed in [10971].

When the radar doesn't rotate, change zoom levels to 1/2/3 only, and display every map tile as 1/2x2/3x3 pixels. The committed version doesn't do the scaling right, so I reverted it in [10974].


Issue migrated from trac:1923 at 2022-04-15 22:02:18 -0700

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file 0001-Display-radar-unblurred-when-not-rotating.patch (4.5 KiB)

@wzdev-ci
Copy link
Contributor Author

Zarel commented


Whoops, I replied on the ML because I didn't know there was a ticket. Here's my ML response:

Hmm. While I'm all in favor of less blurriness in Warzone (especially w.r.t. text - we really need a replacement for QGLC), I don't think radar is the right place for it. I'm pretty sure people would want to zoom the radar in and out in finer steps than just "normal, double, triple". The increments should really be no more than 0.5 and preferably 0.25...

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Well, this is just for the non-rotating radar, which is not default has to be activated in the config file. So for most users, nothing would change.

@wzdev-ci
Copy link
Contributor Author

Zarel commented


Still. Giving rotating and non-rotating different zoom-steps seems like a bad idea.

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


As I see it, those are two different radar modes, so they don't need to behave the same. And I guess (but I'll implement it to see how it looks) that switching between blurred and unblurred will be stranger than differing zoom steps.

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file 0001-Make-the-fixed-radar-unblurred-at-full-zoom-steps.patch (4.5 KiB)

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


That patch keeps the current zoom steps (and increases zoom range to 0.5-4x), though I don't see any reason to use any of the in-between modes, they look much worse.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jun 26, 2010

cybersphinx commented


Replying to Warzone2100/old-trac-import#1923 (comment:3):

Still. Giving rotating and non-rotating different zoom-steps seems like a bad idea.

So, have you tried the latest patch?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 1, 2010

the_cybersphinx commented


(In [11082]) Make the fixed radar unblurred at full zoom steps.

Also increase radar zoom range to 0.5-4x. Refs #1923.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 1, 2010

the_cybersphinx commented


(In [11085]) Make the fixed radar unblurred at full zoom steps.

Also increase radar zoom range to 0.5-4x. Refs #1923.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 1, 2010

Git SVN Gateway <gateway@...> commented


(In Warzone2100/warzone2100@fe7b196) Make the fixed radar unblurred at full zoom steps.

Also increase radar zoom range to 0.5-4x. Refs #1923.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11085 4a71c877-e1ca-e34f-864e-861f7616d084

@wzdev-ci
Copy link
Contributor Author

the_cybersphinx changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

the_cybersphinx set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

the_cybersphinx commented


(In [11130]) 2.3: Make the fixed radar unblurred at full zoom steps.

Also increase radar zoom range to 0.5-4x. Closes #1923.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Oct 9, 2010

Git SVN Gateway <gateway@...> commented


In Warzone2100/warzone2100@fe7b196:

#CommitTicketReference repository="" revision="fe7b1960a288ee1c7ce52c5d6aeeaaf1dceed437"
Make the fixed radar unblurred at full zoom steps.

Also increase radar zoom range to 0.5-4x. Refs #1923.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11085 4a71c877-e1ca-e34f-864e-861f7616d084

1 similar comment
@wzdev-ci
Copy link
Contributor Author

Git SVN Gateway <gateway@...> commented


In Warzone2100/warzone2100@fe7b196:

#CommitTicketReference repository="" revision="fe7b1960a288ee1c7ce52c5d6aeeaaf1dceed437"
Make the fixed radar unblurred at full zoom steps.

Also increase radar zoom range to 0.5-4x. Refs #1923.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11085 4a71c877-e1ca-e34f-864e-861f7616d084

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant