Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Remove "Sk-" from map names #1971

Closed
wzdev-ci opened this issue Jul 4, 2010 · 15 comments
Closed

Remove "Sk-" from map names #1971

wzdev-ci opened this issue Jul 4, 2010 · 15 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Jul 4, 2010

keyword_maps resolution_fixed type_patch (an actual patch, not a request for one) | by Zarel


This patch removes "Sk-" and "-T1" from map names in the game hosting screen. "Sk-" is now also optional in Challenges INI files and config files.

It also breaks netcode compatibility (one-way-only; you can still join 2.3.1 host games, but 2.3.1 can't join your hosted games), but fortunately that's no longer a concern.


Issue migrated from trac:1971 at 2022-04-15 22:05:39 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 4, 2010

Zarel uploaded file mapnames.patch (1.8 KiB)

Remove "Sk-" and "-T1" from map names in map chooser

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 4, 2010

Zarel changed status from new to accepted

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 4, 2010

Zarel changed owner from `` to Zarel

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 4, 2010

Zarel changed type from bug to patch

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 4, 2010

Per commented


Good. Even better if you chopped off Sk- from the .lev files as well. (sed is your friend.)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jul 4, 2010

Zarel commented


I'm afraid of the side effects that could have (there could be naming conflicts - no "Sk-" map names are reserved for legacy campaign-type maps that are still in the .lev standard).

Plus, that'd involve changing the .lev standard, and changing EditWorld and FlaME... bit much work for something that isn't user-facing.

@wzdev-ci
Copy link
Contributor Author

Buginator commented


FYI, this was applied in [11112] for 2.3, [11113] for trunk, and has NOT been committed in qt-trunk (yet).

I won't close ticket until the commit to qt-trunk is done.

@wzdev-ci
Copy link
Contributor Author

Zarel changed status from accepted to assigned

@wzdev-ci
Copy link
Contributor Author

Zarel changed owner from Zarel to Buginator

@wzdev-ci
Copy link
Contributor Author

Zarel commented


Well, I won't be committing to qt-trunk, so the rest is up to you.

@wzdev-ci
Copy link
Contributor Author

Buginator changed status from assigned to closed

@wzdev-ci
Copy link
Contributor Author

Buginator set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

Buginator commented


(In [11136]) Apply patch #1971 - Remove "Sk-" and "-T1" from map names in map chooser.

Committed, as requested by Zarel
Backport [11113] (trunk) [11112] (2.3)
closes #1971

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 4, 2010

Buginator commented


(In [11382]) Reverting :[11136]

Apply patch #1971 - Remove "Sk-" and "-T1" from map names in map chooser.

Committed, as requested by Zarel
Backport [11113] (trunk) [11112] (2.3)
closes #1971

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 7, 2011

Terminator commented


I dont really understand. Has this patch been reverted ? I'm makeing luncher for the game that sets a map name so I notice that not all maps have a "SK" name prefix.(new maps made with Flame dont use them). Is it possible to fit all maps to one template? I mean to make all maps with "SK" or without it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant