This repository has been archived by the owner on Apr 17, 2022. It is now read-only.
Optimize processAVTile #1987
Labels
Milestone
Comments
|
cybersphinx uploaded file |
|
Per commented Please make the no check version a macro, or this will hurt so much for -O0 debug users. This problem has been solved differently in trunk, with the wavecast code. I proposed we backport the wavecast code for 2.3 (in addition to the above patch). |
|
cybersphinx uploaded file Use the NoChecks version in a few more places. |
|
cybersphinx changed status from |
|
cybersphinx changed resolution from `` to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
resolution_closedtype_patch (an actual patch, not a request for one)| by cybersphinxThis patch is the result of a bit of profiling (highly optimized 2.3 build), where processAVTile came out on top. Splitting mapTile into a version without boundary checking and calling that inside a for-loop over the map (where by definition we are not outside the map) put processAVTile down into the noise (from ~4% to ~0.4%).
This is for 2.3, haven't looked into trunk yet.
Issue migrated from trac:1987 at 2022-04-15 22:06:50 -0700
The text was updated successfully, but these errors were encountered: