EvilGuru uploaded file iniparsernew.patch (54.0 KiB)

Per commented

I would love to hear why you rewrote it, and how it is different. And why you hate comments so much ;-)

dak180 changed _comment0 which not transferred by tractive

EvilGuru commented

The old one made it very difficult to work with sections as you had to go and prefix everything so:

[foo]
bar = spam

requires "foo:bar" as the key. If you're dynamically generating sections (as I do for stored templates) this is a pain as you need sstrcat calls all over the place.

So far as the design went: the dictionary/iniparser distinction was annoying. As were the some of the function names like iniparser_dump. My API should be more consistent and intuitive.

As for why I hate comments: no comment. (But you saw that coming, now, didn't you ;)

Safety0ff uploaded file ini2.diff (55.2 KiB)

Safety0ff commented

ini2.diff

Fix challenges by converting key's to lower case (since they are converted to lower case in iniparser_line)

Note: I didn't fix all possible case sensitivity issues!

Changed PHYSFS_fgets and stuffed it into physfs_ext.h.

Added prototypes for utility functions and put them at the end of the file.

Safety0ff uploaded file ini3.diff (55.5 KiB)

Added Case insensitivity unit test, added case insensitivity to sections

Safety0ff uploaded file ini3.2.diff (55.5 KiB)

Improve case insensitivity selftest

EvilGuru uploaded file ini4.diff (59.1 KiB)

Updated patch; better error handling and documentation.

EvilGuru commented

I've uploaded an updated version of the path. If there are no further suggestions I'll commit it sometime tomorrow.

P.S. The original author needs to look up the term "buffer overflow."

anonymous uploaded file config (0.7 KiB)

anonymous uploaded file ini5.diff (61.2 KiB)

Per changed status from new to closed

Per changed resolution from `` to fixed