Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Scanlines for the videos #2095

Closed
wzdev-ci opened this issue Aug 18, 2010 · 8 comments
Closed

Scanlines for the videos #2095

wzdev-ci opened this issue Aug 18, 2010 · 8 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by cybersphinx


This patch adds scanlines for the videos by doubling the vertical texture size and repeating every line with the pixel values reduced by 50%. Proof of concept atm.


Issue migrated from trac:2095 at 2022-04-15 22:14:39 -0700

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file scanlines.patch (2.9 KiB)

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file scanlines.png (164.5 KiB)

scanlines.png

@wzdev-ci
Copy link
Contributor Author

Buginator commented


Looks good, when I did this, I didn't do your 1/2 (R|G|B) color for the odd scan line, it does make it look better.

However, I also noticed that we would still need two routines for this, since we don't want all the vids to use scanlines (the intel ones).

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


If the small videos are shown 1:1 they'll just be 25% darker. But what I also noticed, the scanlines make the subtitle text harder to read.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 4, 2011

cybersphinx commented


Add an option for scanlines when playing videos.

Shows either no, 50% dimmed or black scanlines. Disabled if the video texture
is too small (needs 2 * video height), or the video is shown so small that the
scanlines can't be noticed.

Refs #2095, #2686.
Changeset: f934b1bfc36a8e6de0ef3da4dddbdb4b5bc04bf8

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2011

cybersphinx changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2011

cybersphinx changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2011

cybersphinx commented


Merged into 2.3 in 689e73b79197b76184d80280a7fc19f955f9b2d0.

@wzdev-ci wzdev-ci closed this as completed May 8, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant