Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

VTOL Repair Station - repair loop #2234

Closed
wzdev-ci opened this issue Oct 18, 2010 · 10 comments
Closed

VTOL Repair Station - repair loop #2234

wzdev-ci opened this issue Oct 18, 2010 · 10 comments

Comments

@wzdev-ci
Copy link
Contributor

keyword_vtol resolution_fixed type_bug | by gaming5@...


I played a skirmish with CPUs.
Attached VTOLs to a VTOL attack tower.

When VTOLs come back for repair (red HP bar) they were repaired, but before 100% HP, the HP bar changed to a red HP bar again (lowered life so the bar become red) and the repair began anew. Before the HP reached 100%, it changed again like before. This loops the whole time.


I used different VTOLs.
I used not only the VTOL attack tower, but also the VTOL attack turret.
Everytime the same bug.

I will investigate it more, if I have time.


I'm using Win7.


Issue migrated from trac:2234 at 2022-04-16 06:41:30 -0700

@wzdev-ci
Copy link
Contributor Author

adimosh commented


I'd like to confirm this. However, it doesn't happen with all VTOLs, I haven't been able to realize what the pattern is. However, with a Bunker Buster Vengeance VTOL, it most certainly happens.

The bug seems to be independent of using VTOL attack towers, turrets, commanders or squadrons.

@wzdev-ci
Copy link
Contributor Author

anonymous commented


I have the same issue ocurring, latest build (as of 25th Oct 2010). I don't use any VTOL attack towers or anything like that - I control them manually. This appears to be independent of VTOL type (tested to affect viper, retribution, and dragon); however I have only had this issue occur when lasers (pulse or heavy) are mounted (I don't use other weapons on vtols)

I have a theory regarding defensive laser walls. When multiple lasers shoot the same target, only the first few shots actually hit the target. The remaining shots go right through to damage any further attacking units; however I think this algorithm may be faulty, causing the residual laser damage to affect my own units, along the same path, but behind the laser. (if distance < range then causeDamage())

I may be totally wrong, but it's a possibility!

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 8, 2010

kacjax commented


It seems like there is some sort of timer that is going off. Every 65 and a half seconds at normal speed all VTOLs under repair reset their health at the same time. If their HP is less than about 300 they are fully repaired. if their HP is more than about 300 they lose 300 HP. Since 65 and a half seconds is how long it takes to heal approx. 300 HP, the cycle continues indefinitely. however If you remove the VTOL from the rearm pad before the timer goes off, and then put it back after you can get it fully repaired.

This timer effect seems like it might affect other units as well, after researching auto repair I've seen some damaged structures explode at the same time. not sure if auto repair is related but it may affect all units under repair.

Maybe there is a cheap fix somewhere that is trying to compensate for a perceive bug in the repair code that is now malfunctioning.

@wzdev-ci
Copy link
Contributor Author

buginator <buginator@...> changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

buginator <buginator@...> changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

buginator <buginator@...> commented


(In Warzone2100/warzone2100@6421c81) CHANGELOG: Fix rearming pads to actually repair units

refs #1581
fixes #2313
fixes #2234

Fix rearming pads so they actually rearm at the speed they're intended to. Also make rearming upgrades affect rearming pad repair speed. Replaces REARM_PAD.currentPtsAdded with REARM_PAD.timeLastUpdated, but savefiles should still be compatible.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@8865 4a71c877-e1ca-e34f-864e-861f7616d084
(cherry picked from commit 75569d156f708b460609f50be5da4c2dbf896cfa)

Conflicts:

src/game.c
src/structure.c

@wzdev-ci
Copy link
Contributor Author

Buginator changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

buginator <buginator@...> commented


In Warzone2100/warzone2100@6421c81:

CHANGELOG: Fix rearming pads to actually repair units

refs #1581
fixes #2313
fixes #2234


Fix rearming pads so they actually rearm at the speed they're intended to. Also make rearming upgrades affect rearming pad repair speed. Replaces REARM_PAD.currentPtsAdded with REARM_PAD.timeLastUpdated, but savefiles should still be compatible.

git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@8865 4a71c877-e1ca-e34f-864e-861f7616d084
(cherry picked from commit 75569d156f708b460609f50be5da4c2dbf896cfa)

Conflicts:

	src/game.c
	src/structure.c

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx changed milestone from 3.0 to unspecified

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx commented


Milestone 3.0 deleted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant