Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Truck build queue indicator not visible #2602

Closed
wzdev-ci opened this issue Mar 28, 2011 · 4 comments
Closed

Truck build queue indicator not visible #2602

wzdev-ci opened this issue Mar 28, 2011 · 4 comments
Labels
closed component: Engine: Graphics normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

keyword_Green_indicator_queue_building_truck resolution_fixed type_bug | by j0shdrunk0nwar

When a truck has been given a task of building factory/research/power modules by way of queuing (holding down the Shift key while clicking on the structures), there used to be a green-colored arrow indicator hovering over the structures in the queue for only a brief moment in the 2.3.x series. However in the master, this doesn't seem to be the case.

Issue migrated from trac:2602 at 2022-04-16 07:55:47 -0700
@wzdev-ci
Copy link
Contributor Author

j0shdrunk0nwar uploaded file wz2100-20110328_201832-Sk-SquaredV7-T3.png (608.0 KiB)

How it works in 2.3.x
wz2100-20110328_201832-Sk-SquaredV7-T3.png

@wzdev-ci
Copy link
Contributor Author

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Cyp commented

Display order arrow, when queueing modules to be built.

Also, simplified
if (!bOrderEffectDisplayed && (psOrder->order != DORDER_BUILD || psOrder->order != DORDER_LINEBUILD || psOrder->order != DORDER_BUILDMODULE || psOrder->order != DORDER_HELPBUILD))
to
if (!bOrderEffectDisplayed)
since psOrder could never be all of DORDER_BUILD, DORDER_LINEBUILD, DORDER_BUILDMODULE and DORDER_HELPBUILD simultaneously. The original condition was
if (!bOrderEffectDisplayed AND (psOrder->order != DORDER_BUILD OR
psOrder->order != DORDER_LINEBUILD OR psOrder->order !=
DORDER_BUILDMODULE OR psOrder->order != DORDER_HELPBUILD))
which uses AND and OR, instead of && and ||, but didn't make much sense, either.

Fixes #2602. Fixes #2732.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: Graphics normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci