Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Server crashes if more than 6 players join a game #273

Closed
wzdev-ci opened this issue Feb 18, 2009 · 12 comments
Closed

Server crashes if more than 6 players join a game #273

wzdev-ci opened this issue Feb 18, 2009 · 12 comments

Comments

@wzdev-ci
Copy link
Contributor

keyword_mp_crash resolution_fixed type_bug | by Per


Patch that fixes the problem attached.

The only thing that worries me is that it looks like this bug must have been there for a very, very long time, if this is what is wrong with it!


Issue migrated from trac:273 at 2022-04-15 17:56:34 -0700

@wzdev-ci
Copy link
Contributor Author

Per uploaded file netw1.diff (0.7 KiB)

Patch to fix crash on server if more than 6 players join

@wzdev-ci
Copy link
Contributor Author

Per changed status from new to accepted

@wzdev-ci
Copy link
Contributor Author

Per changed owner from `` to Per

@wzdev-ci
Copy link
Contributor Author

Per commented


I should add by way of explanation that the bug is that the connection count overflows the maximum size of the connected_bsocket array. There is also another bug fix included, which makes the game not crash if connected_bsocket[i] == NULL, which is a rather strange case that I have only seen once.

@wzdev-ci
Copy link
Contributor Author

EvilGuru commented


Can anyone confirm in 2.1? If so we should backport, IMO.

@wzdev-ci
Copy link
Contributor Author

Per commented


Tested on and patch written against 2.1.

@wzdev-ci
Copy link
Contributor Author

Zarel changed milestone from 2.2 to 2.1.2

@wzdev-ci
Copy link
Contributor Author

Zarel commented


In fact, this patch arose because in 2.1, it was annoying to rush a 6-player lobby game to start before a 7th person joined and crashed Warzone.

@wzdev-ci
Copy link
Contributor Author

Per changed status from accepted to closed

@wzdev-ci
Copy link
Contributor Author

Per set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator removed milestone (was 2.1.2)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator commented


Milestone 2.1.2 deleted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant