Ticket #2735 (closed bug: fixed)
Savegames with mod don't load the mod anymore
| Reported by: | zydonk | Owned by: | Zarel |
|---|---|---|---|
| Priority: | major | Milestone: | 2.3.9 |
| Component: | Engine: Resource Management | Version: | 3.1 and master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Operating System: | All/Non-Specific |
Description
Map saved with 110 mod in v238 will show trunk research list (and not original 110 list) when reloaded.
Simply replicated by starting game with 110 mod in v238, allow some research development, then save. Reload game and you will find the research list has changed to the trunk version. Note: research advances are not lost: eg Scourge comes fully developed in the 110 mod, but the cycle of upgrades of the rebalanced list will be offered once the game has been saved and reloaded. I have never played the corrupted game far enough to discover if fatal conflicts arise.
Attachments
Change History
comment:2 Changed 9 months ago by anonymous
Works fine up to v236. This same problem was ticketed for v237. Note that mod was amended to resolve probs that arose with v237 - apparently not to do with this research issue. I suspect the research prob has not yet been directly addressed.
comment:4 Changed 9 months ago by zydonk
Tut-tut - thought first response had not uploaded. Anyway: for the record, previous ticket re prob is #2574.
comment:5 Changed 9 months ago by cybersphinx
- Status changed from new to assigned
- Operating System changed from Windows 7 to All/Non-Specific
- Component changed from 1.10 (balance mod) to Engine: Resource Management
- Summary changed from 238 and updated 110 mod: save game fault to Savegames with mod don't load the mod anymore
- Priority changed from normal to major
- Owner changed from Delphinio to Zarel
- Version changed from 2.3.8 to 2.3 and master
- Keywords research removed
As mentioned in #2574, I'm not sure about the problem in 2.3.7. In 2.3.8, bisecting gives 5e346efd93606c83267ed7f13f7e46cc7dcd219d as the first commit where loading a 1.10-mod savegame fails (says "The required mod could not be loaded: old-1.10-balance\n\nWarzone will try to load the game without it.").
master is broken the same way.
comment:7 Changed 7 months ago by Iluvalar
Here is a quick temporary fix : unzip "old-1.10-balance.wz" in a folder named "old-1.10-balance" this will make the loader reconize your mod correctly.
comment:8 Changed 7 months ago by cybersphinx
Seems even before the patch, modloading from a savegame didn't work when the mod was a .wz. But after it, it doesn't even work when the mod is loaded from the command line, so somewhere it seems the modlist gets cleared where it shouldn't.
comment:9 Changed 7 months ago by vexed
Right. This is more hacks on top of more hacks. We need to revert aed2474ae511c1b49c041f85e5dfd793549725f6 and the other patches as well (that have to do with mod support), and just leave this release in a stable state.
comment:10 Changed 7 months ago by cybersphinx
Possible fix in #2825.
comment:10 Changed 7 months ago by cybersphinx
- Status changed from assigned to closed
- Resolution set to fixed
Don't remove file extensions from mod names.
Fixes loading of savegames with a mod, whether the mod is loaded from the command line or not.
Old savegames won't work unfortunately, and savegames started with a .wz mod won't continue if that mod gets expanded later.
comment:11 Changed 7 months ago by cybersphinx
Don't remove file extensions from mod names.
Fixes loading of savegames with a mod, whether the mod is loaded from the command line or not.
Old savegames won't work unfortunately, and savegames started with a .wz mod won't continue if that mod gets expanded later.
Fixes #2735, closes #2825, #2610.
Conflicts:
src/main.c
Was there an earlier version were this worked?