cybersphinx commented

Was there an earlier version were this worked?

anonymous commented

Works fine up to v236. This same problem was ticketed for v237. Note that mod was amended to resolve probs that arose with v237 - apparently not to do with this research issue. I suspect the research prob has not yet been directly addressed.

dak180 changed _comment0 which not transferred by tractive

zydonk commented

Tut-tut - thought first response had not uploaded. Anyway: for the record, previous ticket re prob is #2574.

cybersphinx changed status from new to assigned

cybersphinx changed operating_system which not transferred by tractive

cybersphinx changed component from 1.10 (balance mod) to Engine: Resource Management

cybersphinx changed title from 238 and updated 110 mod: save game fault to Savegames with mod don't load the mod anymore

cybersphinx changed priority from normal to major

cybersphinx changed owner from Delphinio to Zarel

cybersphinx changed keywords from research to ``

cybersphinx commented

As mentioned in #2574, I'm not sure about the problem in 2.3.7. In 2.3.8, bisecting gives 5e346efd93606c83267ed7f13f7e46cc7dcd219d as the first commit where loading a 1.10-mod savegame fails (says "The required mod could not be loaded: old-1.10-balance\n\nWarzone will try to load the game without it.").

master is broken the same way.

cybersphinx changed milestone from unspecified to 2.3.9

Iluvalar commented

Here is a quick temporary fix :
unzip "old-1.10-balance.wz" in a folder named "old-1.10-balance" this will make the loader reconize your mod correctly.

cybersphinx commented

Seems even before the patch, modloading from a savegame didn't work when the mod was a .wz. But after it, it doesn't even work when the mod is loaded from the command line, so somewhere it seems the modlist gets cleared where it shouldn't.

vexed commented

Right. This is more hacks on top of more hacks.
We need to revert aed2474ae511c1b49c041f85e5dfd793549725f6 and the other patches as well (that have to do with mod support), and just leave this release in a stable state.

cybersphinx commented

Possible fix in #2825.

cybersphinx changed status from assigned to closed

cybersphinx changed resolution from `` to fixed

cybersphinx commented

Don't remove file extensions from mod names.

Fixes loading of savegames with a mod, whether the mod is loaded from
the command line or not.

Old savegames won't work unfortunately, and savegames started with a .wz
mod won't continue if that mod gets expanded later.

Fixes #2735, refs #2825.

• Changeset: [/changeset/5216760744be407deece8d90d4a755dd5f1e421f 5216760744be407deece8d90d4a755dd5f1e421f]
• URL: [5216760744]be407deece8d90d4a755dd5f1e421f

cybersphinx commented

Don't remove file extensions from mod names.

Fixes loading of savegames with a mod, whether the mod is loaded from
the command line or not.

Old savegames won't work unfortunately, and savegames started with a .wz
mod won't continue if that mod gets expanded later.

Fixes #2735, closes #2825, #2610.

Conflicts:

src/main.c 

• Changeset: [/changeset/5886695119364b59f94aa81c3db8d0952dcf59b9 5886695119364b59f94aa81c3db8d0952dcf59b9]
• URL: [5886695119364]b59f94aa81c3db8d0952dcf59b9