Seismo uploaded file devpkg-msvc2010-part-1.7z (2317.5 KiB)

devpkg msvc 2010 part 1

Seismo uploaded file devpkg-msvc2010-part-2.7z (3109.5 KiB)

devpkg msvc2010 part 2

Seismo uploaded file devpkg msvs2010 part 3.7z (43.8 KiB)

devpkg msvc2010 part 3

Seismo uploaded file VisualStudion2010CompileFix.patch (11.1 KiB)

Minimum Compile fix

Seismo uploaded file VisualStudion2010CompileFixEnhanced.patch (27.8 KiB)

Enhanced Compile Fix

Buginator commented

Something wrong with the #2643 dev package ?

Seismo commented

Replying to Warzone2100/old-trac-import#2783 (comment:1):

Something wrong with the #2643 dev package ?
Yes, too much to explain. Would be nice to have this new package. i only missed one preprocessor var for the flex/bison crap (_STDLIB_H) but this generates only a bit noise. May you are able to give me a larger space for uploading the corrected version in one piece.

Per commented

I'll leave it to someone who can verify the patch to commit it (ie buginator), but there are some things in that patch that look wrong.

You compare boolean values against NULL in a lot of places where a bool result is desired. This is surely not a good idea.

All those #if defined(WZ_OS_WIN) || defined(WZ_OS_WIN32) cannot be necessary, since if WZ_OS_WIN32 is true it always defines WZ_OS_WIN in wzglobal.h

The patch does not look like it is against 2.3.8 at all, but rather a pre-C++ version of master...?

Per commented

I see you are still using the svn repository. We are no longer using that. Try our new git repo at https://github.com/Warzone2100 (And this had nothing to do with 2.3.8, so I'm changing the version field...)

Seismo commented

Replying to Warzone2100/old-trac-import#2783 (comment:3):

You compare boolean values against NULL in a lot of places where a bool result is desired. This is surely not a good idea.

The appropriate methods using NULL as a result. I could change the methods instead, but not the windows SDK one...

All those #if defined(WZ_OS_WIN) || defined(WZ_OS_WIN32) cannot be necessary, since if WZ_OS_WIN32 is true it always defines WZ_OS_WIN in wzglobal.h

Yes, this is a mistake but do not harm. This hacked code is full of nonsens, once more should not fed up anyone.

The patch does not look like it is against 2.3.8 at all, but rather a pre-C++ version of master...?

Hmm, ok i really can not figure the version out from SVN... but it must be a master version. I just made this for the last SVN trunk version you can checkout with SVN. Anyone able to explain me how i have to mark this ticket properly?

I see you are still using the svn repository. We are no longer using that. Try our new git repo at https://github.com/Warzone2100 (And this had nothing to do with 2.3.8, so I'm changing the version field...)

Thank you for your Information. May you accept that i am not interested in compiling Qt before i can work with Warzone. So many issues on my Windows 7 machine... I just would like to have the 2.3.8. version source and than i would be very happy...

Safety0ff commented

Replying to Warzone2100/old-trac-import#2783 (comment:5):

Replying to Warzone2100/old-trac-import#2783 (comment:3):

All those #if defined(WZ_OS_WIN) || defined(WZ_OS_WIN32) cannot be necessary, since if WZ_OS_WIN32 is true it always defines WZ_OS_WIN in wzglobal.h

Yes, this is a mistake but do not harm. This hacked code is full of nonsens, once more should not fed up anyone.
Anything that doesn't require extreme effort to do as a non-hack should be done that way. Bottom line.
Hmm, ok i really can not figure the version out from SVN... but it must be a master version. I just made this for the last SVN trunk version you can checkout with SVN. Anyone able to explain me how i have to mark this ticket properly?
SVN was organised has directories, I don't think there's any way to "mark it properly" because it based on old code which the branch isn't known.
I just would like to have the 2.3.8. version source and than i would be very happy...
That's in that github link as well (https://github.com/Warzone2100/warzone2100)

Per changed status from new to closed

Per changed resolution from `` to later

Per commented

The 2.3 source code is available from github using the 2.3 branch, or from the front page using the green download button. Closing this ticket until there is a patch against either master or 2.3.