Modify

Ticket #2824 (closed patch (an actual patch, not a request for one): fixed)

Opened 7 months ago

Last modified 7 months ago

bring back quesoGLC for font handling

Reported by: vexed Owned by:
Priority: normal Milestone: unspecified
Component: Engine: GUI Version: git/master
Keywords: Cc:
Blocked By: Blocking:
Operating System: All/Non-Specific

Description

bring back quesoGLC for font handling. It also solves the strange Vsync on issues in windows.

Attachments

bbglcFonts.patch (17.6 KB) - added by vexed 7 months ago.
bbglcFonts2.patch (17.0 KB) - added by Safety0ff 7 months ago.

Change History

Changed 7 months ago by vexed

comment:1 Changed 7 months ago by Safety0ff

"OPENGLC_LIBS="${OPENGLC_LIBS} ${FONTCONFIG_LIBS} ${FREETYPE_LIBS}""
But FONTCONFIG_LIBS and FREETYPE_LIBS are never set.

I've attached a patch that uses pkgconfig.

Changed 7 months ago by Safety0ff

comment:2 Changed 7 months ago by Safety0ff

Note, the patch was tested with cross compilation, so it's ready to go. Let me know if you want to test the resulting exe.

Last edited 7 months ago by Safety0ff (previous) (diff)

comment:3 Changed 7 months ago by dak180

I have stashed the changes necessary to get the mac builds working with these changes.

comment:4 Changed 7 months ago by vexed

  • Type changed from bug to patch (an actual patch, not a request for one)

Reading http://comments.gmane.org/gmane.comp.fonts.fontconfig/3159 it seems that "* FcFini() is designed to only be called by debugging code from applications, not for normal use by other libraries. "

I guess that means that we can remove this call from quesoGLC, but a better fix would be for the fontconfig guys to fix the way FcFini() & FcInit() works.

Hmmm....

comment:5 Changed 7 months ago by Safety0ff

Right, this issue has been plastered all over the net dating back quite a few years. Ifdef'ing it out of quesoglc might be the way to go.

http://mail-index.netbsd.org/pkgsrc-users/2006/10/05/0004.html (oddly enough the quesoglc source alreay has this.)
http://www.abiword.org/mailinglists/abiword-dev/2006/Sep/0052.html

Oddly enough both Fastdeath and I do not have this issue on our gentoo installations.

I think we've wasted enough time on this, lets move on, shall we?

comment:6 Changed 7 months ago by Fastdeath

Easiest is to deliver our own copy of quesoglc, i say lets do that.

comment:7 Changed 7 months ago by vexed

  • Status changed from new to closed
  • Resolution set to fixed

Bring back quesoGLC to Warzone. This renders the text much faster than what Qt offers, and also fixes issues with Vsync being ON, on windows.

patch fixes by Safety0ff

closes ticket:2824

This patch basically reverts: 828c0f72ae6ff4e10999b3a162e107975820728d Revert 9e29aa52106f873adcb9eb46ff272a9617aca510 which reverted the removal of QuesoGLC, to start

working on fixing the font rendering with Qt.

NOTE: On some systems, there is a assertion failure with FcFini(). We could fix the issue by doing a embed of quesoGLC in our repo, or hope the fontconfig guys fix the issue upstream. See ticket:2824 for more discussion on this issue.

comment:8 Changed 7 months ago by dak180

Bring back QuesoGLC for the mac builds.

X11 (Apple's official version for 10.6) is now required to be installed to run the game.

Refs #2824.

Last edited 7 months ago by dak180 (previous) (diff)

comment:9 follow-up: ↓ 10 Changed 7 months ago by cybersphinx

  • Status changed from closed to reopened
  • Resolution fixed deleted

The game is still haunted by qt text drawing in some places, like the in game console, or the chat in the game setup screen (see #2565).

comment:10 in reply to: ↑ 9 Changed 7 months ago by Safety0ff

Replying to cybersphinx:

The game is still haunted by qt text drawing in some places, like the in game console, or the chat in the game setup screen (see #2565).

Mhmm, see the WzMainWindow::instance()->drawPixmap calls in console.cpp. IIRC it was done this way to accelerate font rendering.

comment:11 Changed 7 months ago by vexed

  • Status changed from reopened to closed
  • Resolution set to fixed

For commit ebc8976dc1ec8aa7d6e839b6df3084a0bbf3d6dd the wrong stash was used. Reapplying missing part of patch.

closes ticket:2824

Revert "Speed up text rendering for console messages by rendering to pixmaps instead of re-rendering the strings themselves for every display frame."

This reverts commit aaedaabf60bf4026ddd7d5028dd4e5099e71ffb6.

View

Add a comment

Provide an email address (will not be publicly visible) in the Author field or register an account (uses your forum account).

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.