Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Some droids fall out of transport when loading game. #2889

Closed
wzdev-ci opened this issue Sep 15, 2011 · 5 comments
Closed

Some droids fall out of transport when loading game. #2889

wzdev-ci opened this issue Sep 15, 2011 · 5 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by Cyp


Since ini.childGroups() apparently returns a list in unspecified order, which in my current Qt version seems to be alphabetically sorted, some droids are loaded before the transport that they are in.

In case the order changes in a future Qt version (to a hashmap instead of an alphabetically sorted map, for example), ini.childGroups() probably shouldn't be used at all, due to risk of desynch due to different Qt versions.

The order that the droids are saved in should probably be saved in a QStringList, and the list should be used to decide the droid loading order.

That probably applies to ini.childKeys(), too.


Issue migrated from trac:2889 at 2022-04-16 08:36:03 -0700

@wzdev-ci
Copy link
Contributor Author

Per commented


Or, once we fix the specific transport problem, we could sort the lists after loading?

@wzdev-ci
Copy link
Contributor Author

Cyp commented


That could work, too.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 6, 2011

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 6, 2011

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 6, 2011

Cyp commented


Fix loading of droids in transporters.

Hopefully fixes #2889 and #2959, but does not handle the corrupted savegame in #2959, which has duplicate droids in droid.ini and mdroid.ini.

  • Changeset: [/changeset/93a6d7ba7489ae8a6c083c6276301dc13ca22824 93a6d7ba7489ae8a6c083c6276301dc13ca22824]
  • URL: [93]a6d7ba7489ae8a6c083c6276301dc13ca22824

@wzdev-ci wzdev-ci closed this as completed Dec 6, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant