Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Mods in autoload not reloaded with savegames #2918

Closed
wzdev-ci opened this issue Oct 19, 2011 · 11 comments
Closed

Mods in autoload not reloaded with savegames #2918

wzdev-ci opened this issue Oct 19, 2011 · 11 comments
Labels
closed component: other major
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by anonymous

Thank you for develop this alternative to original WarZone 2100.
I have downloaded and set 2 mod in
:\Archivos de programa\Warzone 2100\mods\autoload :
new_power_generator.mod.wz
new_textures.mod.wz
They work in the 1st mission and until I save and exit. When I "load" a saved game I get old textures and no longer have the autoloaded in game. In solo play they work.
To recreate this problem in version 2.3.8

  1. start new game (alpha01) and win 1st escenario and save.
  2. exit game
  3. reload game and start game from saved game and NO NEW TEXTURES LOADED
    Thank you.

Issue migrated from trac:2918 at 2022-04-16 08:38:11 -0700
@wzdev-ci
Copy link
Contributor Author

anonymous commented

Did that work in earlier versions?

@wzdev-ci
Copy link
Contributor Author

cybersphinx changed title from No Mods working when loading a saved game. to Mods in autoload not reloaded with savegames

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed priority from normal to major

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented

Still happens. It only occurs when there is more than one mod in the autoload mod folder. The comma that separates the first mod in the list is missing and creates mod.wzsecondmod.wz, thirdmod.wz, ...

Edit: The mods are reloaded with the patch below. Not sure if it breaks anything so please test it.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg uploaded file 0001-Fix-first-mod-not-being-separated-from-others.patch (0.9 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 1, 2017

Cyp commented

Think a better fix might be to move str += s; to after the if (first) { … } block. If I'm reading it right, join({"a", "b", "c"}, ",") would give "ab,c," before the patch and "a,b,c," after, but it was intended to give just "a,b,c".

Since the join function isn't actually used anywhere else, it might not matter, though.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 1, 2017

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 1, 2017

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 1, 2017

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 1, 2017

Berserk Cyborg commented

In Warzone2100/warzone2100@bd2bac6:

#CommitTicketReference repository="" revision="bd2bac6a5a81205f131b2bbe6efb41b6129b0c4c"
Fix mods not separated properly.

The first mod would be missing the comma separator if more than one is currently active.
Fixes #2918.

@wzdev-ci wzdev-ci closed this as completed Aug 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: other major
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci