Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Host always starts with 3 extra trucks in 4c-Pyramidal #2945

Closed
wzdev-ci opened this issue Nov 17, 2011 · 6 comments
Closed

Host always starts with 3 extra trucks in 4c-Pyramidal #2945

wzdev-ci opened this issue Nov 17, 2011 · 6 comments
Labels
closed component: Data: Maps major
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by Cyp

No matter which slot the host is in, in 4c-Pyramidal, the host starts with 3 extra trucks near the middle of the map.

The extra trucks are:

[droid_1501]
id = 1501
position = 8512, 10048, 408
rotation = 0, 0, 0
startpos = 4
template = ConstructionDroid

[droid_1502]
id = 1502
position = 8640, 10048, 408
rotation = 0, 0, 0
startpos = 5
template = ConstructionDroid

[droid_1503]
id = 1503
position = 8768, 10048, 408
rotation = 0, 0, 0
startpos = 6
template = ConstructionDroid

Note they they belong to player 4, 5 and 6, and it's a 4-player map.

They trigger three assertions:

info    |09:17:07: [getPlayer] No player info found!
info    |09:17:07: [getPlayer] Assert in Warzone: ../../src/game.cpp:3935 (false), last script event: '<none>'
info    |09:17:07: [getPlayer] No player info found!
info    |09:17:07: [getPlayer] Assert in Warzone: ../../src/game.cpp:3935 (false), last script event: '<none>'
info    |09:17:07: [getPlayer] No player info found!
info    |09:17:07: [getPlayer] Assert in Warzone: ../../src/game.cpp:3935 (false), last script event: '<none>'

getPlayer() looks at players 0-3, and gives up, asserts, and returns client 0, which is the host.

Don't know whether the map or the code should be fixed, or both. Don't know whether other maps have the same problem.

Issue migrated from trac:2945 at 2022-04-16 08:39:51 -0700
@wzdev-ci
Copy link
Contributor Author

Per commented

This looks like a map problem to me.

@wzdev-ci
Copy link
Contributor Author

Cyp commented

Searching all the maps, it seems to be specific to that map only.

$ grep 'startpos = [4-7]' data/base/multiplay/maps/4c-*/*.ini
data/base/multiplay/maps/4c-pyramidal/droid.ini:startpos = 4
data/base/multiplay/maps/4c-pyramidal/droid.ini:startpos = 5
data/base/multiplay/maps/4c-pyramidal/droid.ini:startpos = 6
$ grep 'startpos = [2-7]' data/base/multiplay/maps/2c-*/*.ini
$

@wzdev-ci
Copy link
Contributor Author

Cyp commented

Fix 3 extra trucks belonging to host on 4c-pyramidal.

The 3 extra trucks belonged to player 4, 5 and 6, and triggered an assertion.

Fixes #2945.

  • Changeset: [/changeset/54080cc5561a65c5cda0939b8a766c44475211f2 54080cc5561a65c5cda0939b8a766c44475211f2]
  • URL: [54080]cc5561a65c5cda0939b8a766c44475211f2

@wzdev-ci
Copy link
Contributor Author

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Mysteryem commented

Yes, this was a problem with the map when I made it in editworld originally. It simply refused to compile unless I placed those trucks for the unused players. Up until this point, they wouldn't appear on the map unless scavengers were turned on, in which case the scavengers would immediately destroy them, hence why it has gone unnoticed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Data: Maps major
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci