Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Fix for players colors #2972

Closed
wzdev-ci opened this issue Dec 9, 2011 · 32 comments
Closed

Fix for players colors #2972

wzdev-ci opened this issue Dec 9, 2011 · 32 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Dec 9, 2011

keyword_palette resolution_fixed type_patch (an actual patch, not a request for one) | by MaNGusT


changed colors to look more "right" in game.


Issue migrated from trac:2972 at 2022-04-16 08:41:37 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 9, 2011

MaNGusT commented


I changed comments for colors names but they also must be changed in somewhere else to show in game properly.

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file dont-use-hardcoloured-teamcolours.patch (2.9 KiB)

This patch makes the game always use the team colours from palette.txt. Those are way too dark / unsaturated for map preview / radar though.

@wzdev-ci
Copy link
Contributor Author

MaNGusT uploaded file palette.txt (2.6 KiB)

"extracted" 8 original colors from textures and changed others to be more saturated

@wzdev-ci
Copy link
Contributor Author

dak180 changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Better, I think.

Green: Too blue and indistinctive.

Orange: Ok, though it could be a bit brighter and more red.

Red: Ok.

Blue: Ok.

Purple (originally pink): Good for purple, not so for pink.

Cyan: Looks rather turquoise, either rename or use as separate colour.

Yellow: Somewhat aggressive, not sure if it should be changed.

Violet (originally purple): Too blue and aggressive. Maybe use this for ultraviolet?

Looks like you changed the later colours as well, can't see them in-game though. Not sure about the renaming as well.

Of the colours themselves I like the red, blue, cyan, purple. Maybe the orange could be a bit brighter and red, the yellow a bit less aggressive. Leaves the ultraviolet and green.

All imo of course.

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file 0001-team-colours.patch (1.5 KiB)

Played around a bit as well, proposal for the ten colours we currently use.

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file default-wz2100-20111212_215745-NTW10-T1.jpg (207.9 KiB)

default-wz2100-20111212_215745-NTW10-T1.jpg

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file mangust-wz2100-20111212_220036-NTW10-T1.jpg (226.0 KiB)

mangust-wz2100-20111212_220036-NTW10-T1.jpg

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file cyberphinx-wz2100-20111212_220136-NTW10-T1.jpg (215.4 KiB)

cyberphinx-wz2100-20111212_220136-NTW10-T1.jpg

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file tc.zip (152.5 KiB)

@wzdev-ci
Copy link
Contributor Author

cybersphinx changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Three screenshots comparing the three versions. Top left to bottom right: purple (Mangust: violet), yellow, cyan, pink (Mangust: purple), blue, red, black, grey, orange, green. Hm, and I just notice that I didn't test the grey and used Mangust's, though I prefer the original one.

The savegame needs Noq's 10c-NTW10.wz map, then just do the "deity" cheat.

@wzdev-ci
Copy link
Contributor Author

cybersphinx changed _comment1 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

MaNGusT commented


I still think that my violet and purple are more different then your pink and purple. I should change my aggressive yellow and violet to a more smooth tones, and fix the green tone.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 12, 2011

dak180 commented


Replying to Warzone2100/old-trac-import#2972 (comment:3):

Three screenshots comparing the three versions. Top left to bottom right: purple (mangust: violet), yellow, cyan, pink (mangust: purple), blue, red, black, grey, orange, green.

I think I like MaNGusT's cyan better than yours but prefer your colours for the rest; though the yellow and pink may need to be a bit more muted.

Maybe b3,24,a8 for pink and c9,bd,22 for yellow.

@wzdev-ci
Copy link
Contributor Author

dak180 uploaded file samples.png (80.6 KiB)

samples.png

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file tc2.patch (1.2 KiB)

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file cybersphinx2.jpg (127.8 KiB)

Better orange, and slightly tweaked pink, purple and yellow.
cybersphinx2.jpg

@wzdev-ci
Copy link
Contributor Author

cybersphinx changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


http://h11.abload.de/img/wz2100-20111213_01392w3jvj.jpg - the lowest six are from the current palette.

white: e0e0e0e

blue: 2020ff

green: 00a000

dark red: 400000

dark blue: 100040

dark green: 406000

http://h8.abload.de/img/wz2100-20111213_01465a75jv.jpg - with teal instead of cyan, and the last six from Mangust's palette.

white: e0e0e0 (same)

bright blue: 7ab1cc

bright green: 55ff00

pink: ffc0c0

lime green: 88dd00

brown: 944b00

@wzdev-ci
Copy link
Contributor Author

MaNGusT commented


my lime green looks out of place :/, I just didn't know how to test all colors...

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 13, 2011

dak180 commented


Replying to Warzone2100/old-trac-import#2972 (comment:6):

http://h11.abload.de/img/wz2100-20111213_01392w3jvj.jpg - the lowest six are from the current palette.

white: e0e0e0e

blue: 2020ff

green: 00a000

dark red: 400000

dark blue: 100040

dark green: 406000

http://h8.abload.de/img/wz2100-20111213_01465a75jv.jpg - with teal instead of cyan, and the last six from Mangust's palette.

white: e0e0e0 (same)

bright blue: 7ab1cc

bright green: 55ff00

pink: ffc0c0

lime green: 88dd00

brown: 944b00
I like:

white: e0e0e0 (same)

bright blue: 7ab1cc

pink: ffc0c0

brown: 944b00

dark red: 400000

dark blue: 100040

And of course I prefer the teal.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

Cyp changed priority from normal to blocker

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

Cyp commented


Don't know what the colours should be, but probably can't go worse than my randomly chosen/named colours (I think I actually chose the colour hex values without looking at the result).

Changing priority, since this is easy to fix (once deciding on the colours), and is unlikely to introduce bugs.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx changed priority from blocker to trivial

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Jan 3, 2012

cybersphinx changed milestone from unspecified to 3.0

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Update team colours to correspond to their names better.

Refs #2972, tc2.patch. No teal for now, since that would introduce new
strings.

  • Changeset: [/changeset/0e382794a5630a82e9aa2376af09a10837f6fb5e 0e382794a5630a82e9aa2376af09a10837f6fb5e]
  • URL: [0]e382794a5630a82e9aa2376af09a10837f6fb5e

2 similar comments
@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Update team colours to correspond to their names better.

Refs #2972, tc2.patch. No teal for now, since that would introduce new
strings.

  • Changeset: [/changeset/0e382794a5630a82e9aa2376af09a10837f6fb5e 0e382794a5630a82e9aa2376af09a10837f6fb5e]
  • URL: [0]e382794a5630a82e9aa2376af09a10837f6fb5e

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Update team colours to correspond to their names better.

Refs #2972, tc2.patch. No teal for now, since that would introduce new
strings.

  • Changeset: [/changeset/0e382794a5630a82e9aa2376af09a10837f6fb5e 0e382794a5630a82e9aa2376af09a10837f6fb5e]
  • URL: [0]e382794a5630a82e9aa2376af09a10837f6fb5e

@wzdev-ci
Copy link
Contributor Author

cybersphinx changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

cybersphinx changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 4, 2012

cybersphinx commented


Update team colours to correspond to their names better.

Refs #2972, tc2.patch. No teal for now, since that would introduce new
strings.

  • Changeset: [/changeset/0e382794a5630a82e9aa2376af09a10837f6fb5e 0e382794a5630a82e9aa2376af09a10837f6fb5e]
  • URL: [0]e382794a5630a82e9aa2376af09a10837f6fb5e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant