Safety0ff edited the issue description

Safety0ff commented

Just needs Mac method and more testing.

Safety0ff uploaded file 0001-Add-SDL1.2swapintervalsupport..patch (6.4 KiB)

vexed commented

I am not sure why you are doing this, this way, that commit that you showed before shouldn't matter in this case.
Glew is already init at the point the frontend is up and running, so we shouldn't have any issues by doing it like this patch.
(tested only on windows)

vexed uploaded file 0001-Enable-Vsync-toggle-with-SDL.patch (1.1 KiB)

vexed commented

BTW, you need glew 1.7.0 it seems, and that was released on [08-26-11] GLEW 1.7.0.

Safety0ff commented

@ 0001-Enable-Vsync-toggle-with-SDL.patch​ added:

You need GLX_SWAP_INTERVAL_EXT and GLX_MESA_SWAP_control to get best coverage. GLX_SGI_SWAP_control slightly differs from the other two (cannot disable, doesn't include a getter).

safety0ff commented

Add swap interval support for SDL 1.2 backend on Windows and Linux.

Refs #3054.

• Changeset: [/changeset/358dcb434a85083e415457d7f07afe95f47f0aa8 358dcb434a85083e415457d7f07afe95f47f0aa8]
• URL: [358]dcb434a85083e415457d7f07afe95f47f0aa8

dak180 commented

The current mac patch has the following issue:

lib/sdl/swapinterval.mm: In function 'int wzGetSwapInterval()':
lib/sdl/swapinterval.mm:20: error: 'context' was not declared in this scope

Safety0ff uploaded file 0001-Add-MacSDLswapintervalsupport..patch (1.4 KiB)

This should work now.

Safety0ff changed milestone from unspecified to 3.1

Safety0ff commented

dak180 added the mac build system changes to this patch here: https://github.com/dak180/warzone2100/commits/topic/sdlswap

safety0ff changed status from new to closed

safety0ff changed resolution from `` to fixed

safety0ff commented

Add Mac SDL swap interval support.

Closes #3054.

Signed-off-by: dak180

• Changeset: [/changeset/764e0c2134d56bb8b3845a4ec434a571d5a64343 764e0c2134d56bb8b3845a4ec434a571d5a64343]
• URL: [764]e0c2134d56bb8b3845a4ec434a571d5a64343

safety0ff commented

Add swap interval support for SDL 1.2 backend on Windows and Linux.

Refs #3054.

• Changeset: [/changeset/358dcb434a85083e415457d7f07afe95f47f0aa8 358dcb434a85083e415457d7f07afe95f47f0aa8]
• URL: [358]dcb434a85083e415457d7f07afe95f47f0aa8

safety0ff commented

Add Mac SDL swap interval support.

Closes #3054.

Signed-off-by: dak180

• Changeset: [/changeset/764e0c2134d56bb8b3845a4ec434a571d5a64343 764e0c2134d56bb8b3845a4ec434a571d5a64343]
• URL: [764]e0c2134d56bb8b3845a4ec434a571d5a64343