Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Players able to join games that are already full #3089

Closed
wzdev-ci opened this issue Jan 30, 2012 · 13 comments
Closed

Players able to join games that are already full #3089

wzdev-ci opened this issue Jan 30, 2012 · 13 comments
Labels
closed component: Engine: Networking normal
Milestone
3.1

Comments

@wzdev-ci
Copy link
Contributor

keyword_Room_full resolution_fixed type_bug | by JDW

Hosted a 4 player game, which had another human player and two other AI. Strangely players were able to join the pre-game room, and were chatting with us and even changing their names. Once we launched the game, we noticed that there were other players in the game with us as players 5, 6...

Though these players did not have any units/structures and were not able to view anything on the map except the dark terrain.

Issue migrated from trac:3089 at 2022-04-16 08:49:08 -0700
@wzdev-ci
Copy link
Contributor Author

cybersphinx changed milestone from unspecified to 3.1

@wzdev-ci
Copy link
Contributor Author

JDW uploaded file gamejoin.png (124.6 KiB)

Players joining and leaving room even as it was full
gamejoin.png

@wzdev-ci
Copy link
Contributor Author

JDW uploaded file gamejoin2.png (1090.4 KiB)

crabster in our 4 player game as player 5
gamejoin2.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

vexed changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

vexed changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

vexed commented

Don't go past the map's player limits when allocating players. fixes #3089

  • Changeset: [/changeset/7f7390cb7e1085a5c22cbb55440e679eb9d6506f 7f7390cb7e1085a5c22cbb55440e679eb9d6506f]
  • URL: [7]f7390cb7e1085a5c22cbb55440e679eb9d6506f

@wzdev-ci wzdev-ci closed this as completed Feb 3, 2012
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

vexed commented

Don't go past the map's player limits when allocating players. fixes #3089

  • Changeset: [/changeset/7f7390cb7e1085a5c22cbb55440e679eb9d6506f 7f7390cb7e1085a5c22cbb55440e679eb9d6506f]
  • URL: [7]f7390cb7e1085a5c22cbb55440e679eb9d6506f

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

cybersphinx commented

Merge branch 'bugfixes' into 3.1

  • bugfixes:
    Check if we actually need to hide widgets before hiding them
    Fix player counts for both AI & humans & 'closed' slots in MP games
    Should fix indicator for loading, skirmish & MP screens. fixes Checkbox not ticked when Host clicks ready in Multiplayer games #3104
    Fix calling batch file for autorevision.sh script refs: 17596232cc207da5007d2120aec849b8db5ea943
    Don't go past the map's player limits when allocating players. fixes Players able to join games that are already full #3089
    Fix issues that were overlooked from the revert(s) in ac550acd58b9f65bf0a4f68b02131b0f108d1021
    qtscript: Add a note about local variables to the documentation.
    Splice in the Changelog from 2.3.
    Set radarOnScreen to true by default.
    Add general rules script for the campaign.
    Run eventStartLevel always, not only for skirmish.
  • Changeset: [/changeset/74c3a8983aac6a95c1b0425689d11ec3b2636511 74c3a8983aac6a95c1b0425689d11ec3b2636511]
  • URL: [74]c3a8983aac6a95c1b0425689d11ec3b2636511

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

vexed commented

Don't go past the map's player limits when allocating players. fixes #3089

  • Changeset: [/changeset/7f7390cb7e1085a5c22cbb55440e679eb9d6506f 7f7390cb7e1085a5c22cbb55440e679eb9d6506f]
  • URL: [7]f7390cb7e1085a5c22cbb55440e679eb9d6506f

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

cybersphinx commented

Merge branch 'bugfixes'

  • bugfixes:
    Check if we actually need to hide widgets before hiding them
    Fix player counts for both AI & humans & 'closed' slots in MP games
    Should fix indicator for loading, skirmish & MP screens. fixes Checkbox not ticked when Host clicks ready in Multiplayer games #3104
    Fix calling batch file for autorevision.sh script refs: 17596232cc207da5007d2120aec849b8db5ea943
    Don't go past the map's player limits when allocating players. fixes Players able to join games that are already full #3089
    Fix issues that were overlooked from the revert(s) in ac550acd58b9f65bf0a4f68b02131b0f108d1021
    qtscript: Add a note about local variables to the documentation.
    Splice in the Changelog from 2.3.
    Set radarOnScreen to true by default.
    Add general rules script for the campaign.
    Run eventStartLevel always, not only for skirmish.
  • Changeset: [/changeset/73ec38c34711746c98d989164124bc210ca246c4 73ec38c34711746c98d989164124bc210ca246c4]
  • URL: [73]ec38c34711746c98d989164124bc210ca246c4

1 similar comment
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 3, 2012

cybersphinx commented

Merge branch 'bugfixes'

  • bugfixes:
    Check if we actually need to hide widgets before hiding them
    Fix player counts for both AI & humans & 'closed' slots in MP games
    Should fix indicator for loading, skirmish & MP screens. fixes Checkbox not ticked when Host clicks ready in Multiplayer games #3104
    Fix calling batch file for autorevision.sh script refs: 17596232cc207da5007d2120aec849b8db5ea943
    Don't go past the map's player limits when allocating players. fixes Players able to join games that are already full #3089
    Fix issues that were overlooked from the revert(s) in ac550acd58b9f65bf0a4f68b02131b0f108d1021
    qtscript: Add a note about local variables to the documentation.
    Splice in the Changelog from 2.3.
    Set radarOnScreen to true by default.
    Add general rules script for the campaign.
    Run eventStartLevel always, not only for skirmish.
  • Changeset: [/changeset/73ec38c34711746c98d989164124bc210ca246c4 73ec38c34711746c98d989164124bc210ca246c4]
  • URL: [73]ec38c34711746c98d989164124bc210ca246c4

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 4, 2012

vexed commented

Don't go past the map's player limits when allocating players. fixes #3089

  • Changeset: [/changeset/7f7390cb7e1085a5c22cbb55440e679eb9d6506f 7f7390cb7e1085a5c22cbb55440e679eb9d6506f]
  • URL: [7]f7390cb7e1085a5c22cbb55440e679eb9d6506f

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 4, 2012

cybersphinx commented

Merge branch 'bugfixes'

  • bugfixes:
    Check if we actually need to hide widgets before hiding them
    Fix player counts for both AI & humans & 'closed' slots in MP games
    Should fix indicator for loading, skirmish & MP screens. fixes Checkbox not ticked when Host clicks ready in Multiplayer games #3104
    Fix calling batch file for autorevision.sh script refs: 17596232cc207da5007d2120aec849b8db5ea943
    Don't go past the map's player limits when allocating players. fixes Players able to join games that are already full #3089
    Fix issues that were overlooked from the revert(s) in ac550acd58b9f65bf0a4f68b02131b0f108d1021
    qtscript: Add a note about local variables to the documentation.
    Splice in the Changelog from 2.3.
    Set radarOnScreen to true by default.
    Add general rules script for the campaign.
    Run eventStartLevel always, not only for skirmish.
  • Changeset: [/changeset/73ec38c34711746c98d989164124bc210ca246c4 73ec38c34711746c98d989164124bc210ca246c4]
  • URL: [73]ec38c34711746c98d989164124bc210ca246c4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: Networking normal
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
1 participant
@wzdev-ci