cybersphinx commented

Replying to [#3094 matthewfarmery]:

only trucks seems to be unaffected by this, not really got far into the game, but noticed most units I can make don't remain when loading a save

Tried it, and even the truck isn't available after loading.

matthewfarmery commented

hmm strange, for me, trucks remain, saying that, it could be random, as one time, I only had repair trucks still visible, while all others including trucks are gone from the factory build menu

Per Inge Mathisen changed status from new to closed

Per Inge Mathisen changed resolution from `` to fixed

Per Inge Mathisen commented

Fix #3094 unit designs in factory menu not appearing when saving and loading.

• Changeset: [/changeset/6f7e523bc18d9c508c104c3917712400b1c53b4f 6f7e523bc18d9c508c104c3917712400b1c53b4f]
• URL: [6]f7e523bc18d9c508c104c3917712400b1c53b4f

cybersphinx commented

Merge branch 'bugfixes' into 3.1

• bugfixes:
  Fix cross-compilation.
  Add assert for droids added to wrong group.
  qtscript: Try harder not to crash if we fail to load our script context.
  Fix unit designs in factory menu not appearing when saving and loading #3094 unit designs in factory menu not appearing when saving and loading.
  Better repo detection for autorevision.sh.
  Revert "Remove hg stuff from autorevision.sh."
  Remove hg stuff from autorevision.sh.
  Remove redundant dependency for version.o.
  Move WZ_WRITEDIR to frame.h and use it for the crashdumps as well.
  Disentangle some Mac includes.
  Actually initialize SDL paste system somewhere.
  Fix crash in semperfi-js

Conflicts:
src/main.cpp

• Changeset: [/changeset/e756e7fe14632059f8f39c8ad3c0ecdc1d42531f e756e7fe14632059f8f39c8ad3c0ecdc1d42531f]
• URL: Warzone2100/warzone2100@e756e7f

cybersphinx commented

Merge branch 'bugfixes'

• bugfixes:
  Fix cross-compilation.
  Add assert for droids added to wrong group.
  qtscript: Try harder not to crash if we fail to load our script context.
  Fix unit designs in factory menu not appearing when saving and loading #3094 unit designs in factory menu not appearing when saving and loading.
• Changeset: [/changeset/2a39eac322038ff72c5c7463796a6a2f3c20d889 2a39eac322038ff72c5c7463796a6a2f3c20d889]
• URL: [2]a39eac322038ff72c5c7463796a6a2f3c20d889

cybersphinx changed status from closed to reopened

cybersphinx changed resolution from fixed to ``

cybersphinx commented

The fix works in the campaign, but not skirmish (see also #3129).

cybersphinx changed milestone from unspecified to 3.1

vexed commented

Is this still a issue in beta 10 ?

matthewfarmery commented

I tested this again in beta 10, both skirmish and SP, units that I designed remain in the factory build menu after saving and loading

so this bug seems to be fixed, unless someone else has problems still, I think this bug can be closed

vexed changed status from reopened to closed

vexed changed resolution from `` to closed

vexed commented

Thanks for the update.

Per Inge Mathisen changed resolution from closed to fixed

Per Inge Mathisen commented

Fix #3094 unit designs in factory menu not appearing when saving and loading.

• Changeset: [/changeset/6f7e523bc18d9c508c104c3917712400b1c53b4f 6f7e523bc18d9c508c104c3917712400b1c53b4f]
• URL: [6]f7e523bc18d9c508c104c3917712400b1c53b4f

cybersphinx commented

Merge branch 'bugfixes'

• bugfixes:
  Fix cross-compilation.
  Add assert for droids added to wrong group.
  qtscript: Try harder not to crash if we fail to load our script context.
  Fix unit designs in factory menu not appearing when saving and loading #3094 unit designs in factory menu not appearing when saving and loading.
• Changeset: [/changeset/2a39eac322038ff72c5c7463796a6a2f3c20d889 2a39eac322038ff72c5c7463796a6a2f3c20d889]
• URL: [2]a39eac322038ff72c5c7463796a6a2f3c20d889