Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

droids allowed to have 100% damage #3168

Closed
wzdev-ci opened this issue Feb 11, 2012 · 9 comments
Closed

droids allowed to have 100% damage #3168

wzdev-ci opened this issue Feb 11, 2012 · 9 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_Requesting more information about issue type_bug | by effigy


On several occasions I've noticed that droids are allowed to take 100% and still function (specifically Cyborgs).

Also, I have to wonder if this is related to why when a droid is set to retreat at medium damage it won't always retreat when damage indicator is yellow.


Issue migrated from trac:3168 at 2022-04-16 08:54:37 -0700

@wzdev-ci
Copy link
Contributor Author

NoQ commented


I also saw yellow droids that didn't retreat on yellow; looks like some rounding issue.

@wzdev-ci
Copy link
Contributor Author

Emdek commented


Confirming above issue (color bar not synced with damage value).

@wzdev-ci
Copy link
Contributor Author

cybersphinx changed milestone from unspecified to 3.1

@wzdev-ci
Copy link
Contributor Author

Emdek commented


25% damage for tank results in yellow bar but not yet retreat for medium damage setting.

@wzdev-ci
Copy link
Contributor Author

vexed changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

vexed changed resolution from `` to needinfo

@wzdev-ci
Copy link
Contributor Author

vexed commented


In my tests, they do what they need to do, and the damage meter shows the correct display.
All units die when they are below 0 HP... if they have 0 then they aren't dead as far as the game is concerned.

The cyborgs also retreat on damage when they should.

If you guys find a way to replicate the issues you are talking about, let us know.

@wzdev-ci
Copy link
Contributor Author

cybersphinx uploaded file Yellow but doesn't retreat.7z (40.0 KiB)

Group 1 has one yellow droid.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 9, 2012

Lord Apocalypse commented


If 0 HP isnt dead then the logic needs to be changed to if (dmg <= 0) { kill unit }

I have run across this once. Its probably related to the if statement above as the health checking may be flawed.

I am going to try and reproduce and attach a save game for it. If someone can point me to where in the code the all this is handled I might be able to identify something from it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant