NoQ commented

Now i think the stderr log file just reports the directory in which the executable was compiled.

dak180 changed status from new to assigned

dak180 changed owner from `` to per

dak180 changed component from Build system to Engine: Scripting / AI

dak180 commented

Replying to [#3187 aubergine]:

Not sure what it's supposed to contain, but according to NoQ the published betas (referenced on wz2100.net home page) shouldn't be "TRUNK".

Related forum discussion:

http://forums.wz2100.net/viewtopic.php?f=10&p=95449#p95439

Also, NoQ mentioned that the log file was showing "wz2100-git" which apparently is also incorrect?
The "wz2100-git" is a file path on my machine, so there is nothing wrong with that.

The version you are looking at is the one reported by the .js api not the version embeded by the versioning system in the builds; as far as I can tell that is working properly.

vexed commented

It is because

engine->globalObject().setProperty("version", PACKAGE_VERSION, QScriptValue::ReadOnly | QScriptValue::Undeletable);

PACKAGE_VERSION is only used in linux builds, the other builds it isn't really used.
That means, the comment Do not make too many assumption about this value. is pretty much true, since it is useless except on linux.

dak180 commented

It seems like VCS_TAG (from autorevision.h) would be a more reliable source of version info (perhaps in conjunction with VCS_NUM and / or VCS_SHORT_HASH).

vexed commented

Replying to Warzone2100/old-trac-import#3187 (comment:4):

It seems like VCS_TAG (from autorevision.h) would be a more reliable source of version info (perhaps in conjunction with VCS_NUM and / or VCS_SHORT_HASH).

A hash is not a version number.
This needs to have a actual version number, like the netcode does.

dak180 commented

Replying to Warzone2100/old-trac-import#3187 (comment:5):

Replying to Warzone2100/old-trac-import#3187 (comment:4):

It seems like VCS_TAG (from autorevision.h) would be a more reliable source of version info (perhaps in conjunction with VCS_NUM and / or VCS_SHORT_HASH).

A hash is not a version number.
This needs to have a actual version number, like the netcode does.
Which was why I suggested VCS_TAG and VCS_NUM; any VCS_NUM would be unique for a given VCS_TAG and the VCS_TAG will tell you the user reported version or branch name if not built from a tag.

cybersphinx changed status from assigned to closed

cybersphinx changed resolution from `` to fixed

cybersphinx commented

Fixed in b49039fc7defe1ce39174a84ea94784d21502c5d and 5aa2b0c0728fe0586e9477a740ade0506f4b7c53.