Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Mortars broken in master #3267

Closed
wzdev-ci opened this issue Mar 9, 2012 · 9 comments
Closed

Mortars broken in master #3267

wzdev-ci opened this issue Mar 9, 2012 · 9 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Mar 9, 2012

resolution_fixed type_bug | by cybersphinx


Load the savegame. Before 3e78ef96963381def360c5ec2a1c69a6a115439e, all four mortars would shoot at the approaching units, after that only the two on the sides. The savegame is from an older revision, the two outer mortars were built with that, the two in the middle with current master after it was broken. I didn't notice a difference in the savegame, and the above commit doesn't seem to touch building, I guess that one broke visibility in some way, and a later one sensor assignment, so the newly built mortars don't see any targets without sensor.


Issue migrated from trac:3267 at 2022-04-16 09:34:45 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 9, 2012

cybersphinx uploaded file mortars.7z (71.9 KiB)

@wzdev-ci
Copy link
Contributor Author

nloewen commented


I believe I am experiencing the same bug. Mortars will point at units in sensor range, but will only fire if the unit comes into its line of sight. An exception to this is if you have a sensor unit, you can target a structure or unit, and mortars will fire on that targeted unit.

@wzdev-ci
Copy link
Contributor Author

Per commented


There seems to be something wrong with the target pitch calculation. From what I can tell, it wraps around a different direction than what the weapon pitch limits expects.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 2, 2012

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 2, 2012

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 2, 2012

Cyp commented


Adjust turret pitch as far as possible, and no farther.

Weapons could fail to fire, if the desired pitch was outside the limits.

Fixes #3267.

  • Changeset: [/changeset/17d3ea3863fb4b68da6b4bff7a11726d746c1aad 17d3ea3863fb4b68da6b4bff7a11726d746c1aad]
  • URL: [17]d3ea3863fb4b68da6b4bff7a11726d746c1aad

@wzdev-ci wzdev-ci closed this as completed May 2, 2012
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 3, 2012

Cyp commented


Adjust turret pitch as far as possible, and no farther.

Weapons could fail to fire, if the desired pitch was outside the limits.

Fixes #3267.

  • Changeset: [/changeset/17d3ea3863fb4b68da6b4bff7a11726d746c1aad 17d3ea3863fb4b68da6b4bff7a11726d746c1aad]
  • URL: [17]d3ea3863fb4b68da6b4bff7a11726d746c1aad

2 similar comments
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 4, 2012

Cyp commented


Adjust turret pitch as far as possible, and no farther.

Weapons could fail to fire, if the desired pitch was outside the limits.

Fixes #3267.

  • Changeset: [/changeset/17d3ea3863fb4b68da6b4bff7a11726d746c1aad 17d3ea3863fb4b68da6b4bff7a11726d746c1aad]
  • URL: [17]d3ea3863fb4b68da6b4bff7a11726d746c1aad

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 4, 2012

Cyp commented


Adjust turret pitch as far as possible, and no farther.

Weapons could fail to fire, if the desired pitch was outside the limits.

Fixes #3267.

  • Changeset: [/changeset/17d3ea3863fb4b68da6b4bff7a11726d746c1aad 17d3ea3863fb4b68da6b4bff7a11726d746c1aad]
  • URL: [17]d3ea3863fb4b68da6b4bff7a11726d746c1aad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant