Skip to content
This repository was archived by the owner on Apr 17, 2022. It is now read-only.

JS: "unknown attack range order" when ordering some scavenger units to attack. #3359

Closed
wzdev-ci opened this issue Mar 24, 2012 · 11 comments
Closed

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by NoQ


When i issue a DORDER_ATTACK order to any of the scavenger units pre-placed on Sk-Startup (mostly foot soldiers, but one car too), they don't receive the order, but the following assert fails as well. I also wonder if they can shoot at all.

info    |12:03:03: [actionInAttackRange:210] unknown attack range order
info    |12:03:03: [actionInAttackRange:210] Assert in Warzone: action.cpp:210 (!"unknown attackrange order"), last script event: 'N/A'

Issue migrated from trac:3359 at 2022-04-16 09:40:49 -0700

@wzdev-ci
Copy link
Contributor Author

NoQ commented


Hmm. In fact, this seems to apply to all pre-placed combat units, regardless of map or player they belong to.

@wzdev-ci
Copy link
Contributor Author

NoQ uploaded file wz2100-20120329_122106-GangWar02-T1.jpg (455.4 KiB)

Attack range is undefined even for droids belonging to human players.
wz2100-20120329_122106-GangWar02-T1.jpg

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 9, 2012

Per uploaded file fix3359.diff (0.7 KiB)

Does this patch fix the problem? It sets a valid default secondary order for units that do not have one.

@wzdev-ci
Copy link
Contributor Author

NoQ commented


The error message disappears, and all pre-placed units are set to attack at medium distance. But pre-placed units still don't auto-target the enemy unless i tell them to fire at will. Probably all fields need to be initialized in a similar way?

@wzdev-ci
Copy link
Contributor Author

Per Inge Mathisen changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Per Inge Mathisen changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Per Inge Mathisen commented


Keep default secondary order from droid initialization if no replacement order found in savegame. Should fix #3359

@wzdev-ci
Copy link
Contributor Author

Per Inge Mathisen commented


Keep default secondary order from droid initialization if no replacement order found in savegame. Should fix #3359

1 similar comment
@wzdev-ci
Copy link
Contributor Author

Per Inge Mathisen commented


Keep default secondary order from droid initialization if no replacement order found in savegame. Should fix #3359

@wzdev-ci
Copy link
Contributor Author

cybersphinx commented


Merge branch 'bugfixes' into 3.1

  • bugfixes:
    Brazilian translation update by Tucalipe.
    Hungarian translation update by mtomi78.
    Polish translation update by Emdek.
    Fix save game load crash due to dangling, dead target from structures.
    Map fixes and updates: GreatRift, MizaMaze, Wheel.
    Hungarian translation update by mtomi78.
    Keep default secondary order from droid initialization if no replacement order found in savegame. Should fix JS: "unknown attack range order" when ordering some scavenger units to attack. #3359
    Use Clang wherever possible.
  • Changeset: [/changeset/6ed2964db1a23475cb01bf43c8a94164363543d2 6ed2964db1a23475cb01bf43c8a94164363543d2]
  • URL: [6]ed2964db1a23475cb01bf43c8a94164363543d2

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 4, 2012

Per Inge Mathisen commented


Keep default secondary order from droid initialization if no replacement order found in savegame. Should fix #3359

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant