vexed uploaded file 0001-Do-away-with-apsStaticTemplates-completely-it-caused.patch (21.8 KiB)

vexed changed status from new to closed

vexed changed resolution from `` to fixed

vexed commented

Do away with apsStaticTemplates completely, it caused multiple issues. There is no difference in accessing the templates for the AI or Humans now. Only write templates out for active players. Make each template's group unique to each player. Fix clone wars templates. Remove hacky functions GetHumanDroidTemplate & GetAIDroidTemplate fixes #3146 close #3369

refs b99e845d979e89d7735f61cf71c634d0c2b1e033
refs 0cc7c315db4b1b80048e9a45839cdbde5900f698

• Changeset: [/changeset/28c10b00a8f3bf6d87176e3aba8fba65993cedba 28c10b00a8f3bf6d87176e3aba8fba65993cedba]
• URL: [28]c10b00a8f3bf6d87176e3aba8fba65993cedba

Cyp changed status from closed to reopened

Cyp changed resolution from fixed to ``

Cyp commented

In 3-player multiplayer, I see 3 of each template. Two of each three cyborg weapon templates appear as cyborg legs. Reverting 28c10b00a8f3bf6d87176e3aba8fba65993cedba fixes this.

vexed changed status from reopened to closed

vexed changed resolution from `` to fixed

vexed commented

Only populate unique entries for the UI template list.

Fixes #3369

• Changeset: [/changeset/0de0c416297a1694146af7ca82189ee971c93502 0de0c416297a1694146af7ca82189ee971c93502]
• URL: [0]de0c416297a1694146af7ca82189ee971c93502

Cyp changed status from closed to reopened

Cyp changed resolution from fixed to ``

Cyp commented

Templates look normal now, except that the autogame AI never builds anything other than trucks, cyborg engineers and lots of cyborg mechanics. Nexus AI does build tanks.

vexed changed status from reopened to closed

vexed changed resolution from `` to fixed

vexed commented

Only populate unique entries for the UI template list.

Fixes #3369

• Changeset: [/changeset/0de0c416297a1694146af7ca82189ee971c93502 0de0c416297a1694146af7ca82189ee971c93502]
• URL: [0]de0c416297a1694146af7ca82189ee971c93502

cybersphinx changed resolution from fixed to ``

cybersphinx commented

Thank you, automerge.

cybersphinx changed status from closed to reopened

vexed commented

Replying to Warzone2100/old-trac-import#3369 (comment:7):

Templates look normal now, except that the autogame AI never builds anything other than trucks, cyborg engineers and lots of cyborg mechanics. Nexus AI does build tanks.

... more hacks that bite us

vexed changed status from reopened to closed

vexed changed resolution from `` to fixed

vexed commented

Try to fix the autogame hack by introducing a new bool to keep track of
when we should be using the AI's templates.

This only works in debug mode!

TODO: Move the actual setting of this bool script side, in case the user picks
a AI that doesn't support the 'autogame' command.

close #3369

• Changeset: [/changeset/3bebe1a0d6c3e8f230b56def4a823430a2a58c9f 3bebe1a0d6c3e8f230b56def4a823430a2a58c9f]
• URL: [3]bebe1a0d6c3e8f230b56def4a823430a2a58c9f

Cyp changed status from closed to reopened

Cyp changed resolution from fixed to ``

Cyp commented

Desynch on autogame... Other clients didn't find the template.

(Déjà vu — have I reopened this ticket before?)

@@ -296,9 +296,9 @@
 [featureUpdate] > feature119 = p12;pos(6720,6592,168),subtype5,damageable0,body0
 [gameLoop] End game state update, gameTime = 5902
 [recvMessage] Processing player 2, message GAME_STRUCTUREINFO
-[recvStructureInfo] player2,structId163*,structureInfo0,templateId249^
+[recvStructureInfo] player2,structId163*,structureInfo0,templateId249*
 [recvStructureInfo] < structure163 = p2;pos(6976,960,167),status1,type1, ,bld500,body2000
-[recvStructureInfo] > structure163 = p2;pos(6976,960,167),status1,type1, ,bld500,body2000
+[recvStructureInfo] > structure163 = p2;pos(6976,960,167),status1,type1,p249,bld500,body2000
 [recvMessage] Processing player 2, message GAME_STRUCTUREINFO
 [recvStructureInfo] player2,structId164*,structureInfo0,templateId611*
 [recvStructureInfo] < structure164 = p2;pos(6976,1408,164),status1,type16, ,bld500,body1000

vexed changed priority from blocker to normal

vexed commented

˙˙˙uıɐƃɐ sıɥʇ ƃuısolɔ uo nʌ àɾép
Hmm, I guess I could hijack another routine so everyone can toggle the bool in question...

vexed uploaded file 0001-Make-autogame-work-in-debug-mp-games.patch (4.3 KiB)

Cyp commented

Patch looks scary, but seems to work, except that the autogame (Nexus) AI plays very badly. (But that's completely normal, and unrelated to the patch...)

vexed changed status from reopened to closed

vexed changed resolution from `` to fixed

vexed commented

Make 'autogame' work in debug mp games.

fixes #3369

• Changeset: [/changeset/0ad220b334cabb17d356e0132fc07c36624455da 0ad220b334cabb17d356e0132fc07c36624455da]
• URL: [0]ad220b334cabb17d356e0132fc07c36624455da

vexed commented

Make 'autogame' work in debug mp games.

fixes #3369

• Changeset: [/changeset/0ad220b334cabb17d356e0132fc07c36624455da 0ad220b334cabb17d356e0132fc07c36624455da]
• URL: [0]ad220b334cabb17d356e0132fc07c36624455da

vexed commented

Do away with apsStaticTemplates completely, it caused multiple issues. There is no difference in accessing the templates for the AI or Humans now. Only write templates out for active players. Make each template's group unique to each player. Fix clone wars templates. Remove hacky functions GetHumanDroidTemplate & GetAIDroidTemplate fixes #3146 close #3369

refs b99e845d979e89d7735f61cf71c634d0c2b1e033
refs 0cc7c315db4b1b80048e9a45839cdbde5900f698

• Changeset: [/changeset/28c10b00a8f3bf6d87176e3aba8fba65993cedba 28c10b00a8f3bf6d87176e3aba8fba65993cedba]
• URL: [28]c10b00a8f3bf6d87176e3aba8fba65993cedba

vexed commented

Only populate unique entries for the UI template list.

Fixes #3369

• Changeset: [/changeset/0de0c416297a1694146af7ca82189ee971c93502 0de0c416297a1694146af7ca82189ee971c93502]
• URL: [0]de0c416297a1694146af7ca82189ee971c93502

vexed commented

Try to fix the autogame hack by introducing a new bool to keep track of
when we should be using the AI's templates.

This only works in debug mode!

TODO: Move the actual setting of this bool script side, in case the user picks
a AI that doesn't support the 'autogame' command.

close #3369

• Changeset: [/changeset/3bebe1a0d6c3e8f230b56def4a823430a2a58c9f 3bebe1a0d6c3e8f230b56def4a823430a2a58c9f]
• URL: [3]bebe1a0d6c3e8f230b56def4a823430a2a58c9f

vexed commented

Make 'autogame' work in debug mp games.

fixes #3369

• Changeset: [/changeset/0ad220b334cabb17d356e0132fc07c36624455da 0ad220b334cabb17d356e0132fc07c36624455da]
• URL: [0]ad220b334cabb17d356e0132fc07c36624455da