Modify

Ticket #35 (closed bug: fixed)

Opened 3 years ago

Last modified 21 months ago

droids reparing themselves are not ignoring all the events around them anymore.

Reported by: Buginator Owned by:
Priority: normal Milestone:
Component: other Version: 2.1 (unsupported!)
Keywords: Cc: Per, Buginator
Blocked By: Blocking:
Operating System: All/Non-Specific

Description (last modified by Giel) (diff)

Attachments

repairWimpfix.patch (3.2 KB) - added by Buginator 3 years ago.

Change History

Changed 3 years ago by Buginator

comment:1 Changed 3 years ago by Buginator

  • Version set to 2.1
  • Milestone set to 2.1

comment:2 Changed 3 years ago by anonymous

Note, I change psDroid->timeLastHit = UDWORD_MAX; to psDroid->timeLastHit = 0; instead. That means that *without* the ugly UDWORD_MAX check, then old savegames might have a problem.

Anyone know a good reason why they have it set to UDWORD_MAX on init, and not to 0?

I also 'fixed' the droid that is sulking to snap out of it when it is being attacked. Technically, that is a different issue, so I guess I will move that to a new patch.

comment:3 Changed 3 years ago by anonymous

  • Status changed from new to closed
  • Resolution set to invalid

comment:4 Changed 3 years ago by Buginator

  • Status changed from closed to reopened
  • Resolution invalid deleted

comment:5 Changed 3 years ago by anonymous

I think you want break, not return, in the patch. Also a better fix is being worked on in https://gna.org/patch/?1104 but this will more time.

comment:6 Changed 3 years ago by Buginator

I assume that is you Per?

A rewrite is better, so you can close this if you want. Or do this as a temp fix.

comment:7 Changed 3 years ago by Giel

  • Cc Per, Buginator added

Replying to anonymous:

I think you want break, not return, in the patch. Also a better fix is being worked on in 1104 but this will more time.

Any updates on this one?

comment:9 Changed 3 years ago by gerard_

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [6267]) Allow a droid to pick a new target while auto-repairing. This fixes #35 and #12217 where droids would just let themselves be shot to death while repairing themselves slowly.

comment:10 Changed 3 years ago by gerard_

(In [6267]) Backport of r6267: Allow a droid to pick a new target while auto-repairing. This fixes #35 and #12217 where droids would just let themselves be shot to death while repairing themselves slowly.

comment:11 Changed 3 years ago by Giel

  • Description modified (diff)

comment:12 Changed 21 months ago by Buginator

  • Milestone 2.1 deleted

Milestone 2.1 deleted

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.