Shadow Wolf TJC uploaded file wz2100-20120531_151432-Sk-Rush.jpg (340.5 KiB)

10 factories on-screen, with a Commander selected. Note the messed-up orders screen on the bottom left.

vexed changed status from new to closed

vexed changed resolution from `` to later

vexed changed _comment0 which not transferred by tractive

vexed commented

This isn't a bug, it is a limitation.
That is one of the reasons why the game has a hard cap to the number of buildings you can make.

Right now, nothing more than 5 is supported.

Shadow Wolf TJC commented

So I take it that you're not interested in fixing this BECAUSE it's a limitation of the core game, and because you don't care about the modding community, right? Well then, if the devs won't fix this, then who will? :(

vexed commented

Replying to Warzone2100/old-trac-import#3521 (comment:2):

So I take it that you're not interested in fixing this BECAUSE it's a limitation of the core game, and because you don't care about the modding community, right? Well then, if the devs won't fix this, then who will? :(

O_o

... ::sigh::

Your not even in the ballpark.

If someone wants to fix the GUI, then fine, but since this is a current engine limitation, and not a bug, I don't see how you end up making those unfounded accusations.

Trac is for bugs + patches, not feature requests.

Shadow Wolf TJC commented

Sorry.

Shadow Wolf TJC uploaded file extra commander factory icons.rar (38.0 KiB)

I'm still interested in seeing this bug fixed, so I've prepared a few new images for use with the orders menu, 2 of which are blank button icons for a more modular use. However, I don't quite know how to make them show up, sadly. I've tried messing around with intfac.img (which I presume will need to be modified), but it doesn't seem to work at all.

Shadow Wolf TJC changed status from closed to reopened

Shadow Wolf TJC changed resolution from later to ``

vexed changed status from reopened to closed

vexed changed resolution from `` to later

vexed commented

The interface image is only part of the issue, the other part is the code itself.
It isn't as simple as just changing the gfx, unfortunately.
comment:2 still applies to this limitation.

Feel free to open it back up when someone comes up with a patch that will fix the limitation.

Shadow Wolf TJC changed _comment0 which not transferred by tractive

Shadow Wolf TJC commented

I've been taking a look at the code at github, and while I haven't changed anything (I'd only make such changes on my own fork of the Warzone 2100 repository), it seems that src/intfac.h will need some work. However, I'm still trying to find out what scripts control how the orders screen is displayed, so that I could work out a way to display some of the extra buttons below others.

Edit: I believe that this block of code within src/intorder.cpp may need to be changed:

	{
		ORDBUTCLASS_FACTORY,
		DSO_ASSIGN_PRODUCTION,
		DSS_ASSPROD_MASK,
		ORD_BTYPE_BOOLEAN_COMBINE,
		ORD_JUSTIFY_CENTER | ORD_JUSTIFY_NEWLINE,
		IDORDER_ASSIGN_PRODUCTION,
		5,0,
		{IMAGE_ORD_FAC1UP,		IMAGE_ORD_FAC2UP,	IMAGE_ORD_FAC3UP,	IMAGE_ORD_FAC4UP,	IMAGE_ORD_FAC5UP	},
		{IMAGE_ORD_FAC1UP,		IMAGE_ORD_FAC2UP,	IMAGE_ORD_FAC3UP,	IMAGE_ORD_FAC4UP,	IMAGE_ORD_FAC5UP	},
		{IMAGE_ORD_FACHILITE,	IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE	},
		{STR_DORD_FACTORY,	STR_DORD_FACTORY,	STR_DORD_FACTORY,	STR_DORD_FACTORY,	STR_DORD_FACTORY},
		{ 0x01 << DSS_ASSPROD_SHIFT, 0x02 << DSS_ASSPROD_SHIFT, 0x04 << DSS_ASSPROD_SHIFT,
		  0x08 << DSS_ASSPROD_SHIFT, 0x10 << DSS_ASSPROD_SHIFT }
	},
	{
		ORDBUTCLASS_CYBORGFACTORY,
		DSO_ASSIGN_CYBORG_PRODUCTION,
		DSS_ASSPROD_MASK,
		ORD_BTYPE_BOOLEAN_COMBINE,
		ORD_JUSTIFY_CENTER | ORD_JUSTIFY_NEWLINE,
		IDORDER_ASSIGN_CYBORG_PRODUCTION,
		5,0,
		{IMAGE_ORD_FAC1UP,		IMAGE_ORD_FAC2UP,	IMAGE_ORD_FAC3UP,	IMAGE_ORD_FAC4UP,	IMAGE_ORD_FAC5UP	},
		{IMAGE_ORD_FAC1UP,		IMAGE_ORD_FAC2UP,	IMAGE_ORD_FAC3UP,	IMAGE_ORD_FAC4UP,	IMAGE_ORD_FAC5UP	},
		{IMAGE_ORD_FACHILITE,	IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE	},
		{STR_DORD_CYBORG_FACTORY,	STR_DORD_CYBORG_FACTORY,	STR_DORD_CYBORG_FACTORY,	STR_DORD_CYBORG_FACTORY,	STR_DORD_CYBORG_FACTORY},
		{ 0x01 << DSS_ASSPROD_CYBORG_SHIFT, 0x02 << DSS_ASSPROD_CYBORG_SHIFT, 0x04 << DSS_ASSPROD_CYBORG_SHIFT,
		  0x08 << DSS_ASSPROD_CYBORG_SHIFT, 0x10 << DSS_ASSPROD_CYBORG_SHIFT }
	},
	{
		ORDBUTCLASS_VTOLFACTORY,
		DSO_ASSIGN_VTOL_PRODUCTION,
		DSS_ASSPROD_MASK,
		ORD_BTYPE_BOOLEAN_COMBINE,
		ORD_JUSTIFY_CENTER | ORD_JUSTIFY_NEWLINE,
		IDORDER_ASSIGN_VTOL_PRODUCTION,
		5,0,
		{IMAGE_ORD_FAC1UP,		IMAGE_ORD_FAC2UP,	IMAGE_ORD_FAC3UP,	IMAGE_ORD_FAC4UP,	IMAGE_ORD_FAC5UP	},
		{IMAGE_ORD_FAC1UP,		IMAGE_ORD_FAC2UP,	IMAGE_ORD_FAC3UP,	IMAGE_ORD_FAC4UP,	IMAGE_ORD_FAC5UP	},
		{IMAGE_ORD_FACHILITE,	IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE,IMAGE_ORD_FACHILITE	},
		{STR_DORD_VTOL_FACTORY,	STR_DORD_VTOL_FACTORY,	STR_DORD_VTOL_FACTORY,	STR_DORD_VTOL_FACTORY,	STR_DORD_VTOL_FACTORY},
		{ 0x01 << DSS_ASSPROD_VTOL_SHIFT, 0x02 << DSS_ASSPROD_VTOL_SHIFT, 0x04 << DSS_ASSPROD_VTOL_SHIFT,
		  0x08 << DSS_ASSPROD_VTOL_SHIFT, 0x10 << DSS_ASSPROD_VTOL_SHIFT }
	},

I'd personally want to add the extra factory assignment buttons below the others (given the limited space in the orders screen), though I wonder how we're going to do that.

Shadow Wolf TJC changed status from closed to reopened

Shadow Wolf TJC changed resolution from later to ``

Shadow Wolf TJC commented

While I've added in some code that should hopefully fix this ticket, it's only a temporary solution. Later on, we should probably look into finding out how to add the extra factory buttons in a way that's acceptable.

ShadowWolfTJC/warzone2100@392df9b

vexed commented

This doesn't fix anything though, you just are removing a safety net.

As for which files, I don't recall offhand, but usually, it is spread out in a few files.

vexed changed status from reopened to closed

vexed changed resolution from `` to later

vexed commented

Oh, I forgot to mention, no need to reopen the ticket.
I get the mail, so when it comes time to open it (or there is a working patch), then we will open it.

Your just causing more noise with trac when you open them.
"Later" is special, even though trac lists it as closed, it isn't actually closed as far as we are concerned.

Shadow Wolf TJC commented

I see. Sorry about that.

Sigh. I wish that I could create my own snapshots of Warzone 2100 using the resources that are available on my fork. Then I could actually see for myself if the code changes would actually work instead of having to rely upon others to do the actual testing. :(