Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

fails to build from source on non-x86 platforms #3558

Closed
wzdev-ci opened this issue Jun 20, 2012 · 6 comments
Closed

fails to build from source on non-x86 platforms #3558

wzdev-ci opened this issue Jun 20, 2012 · 6 comments
Labels
closed component: Engine: other normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

keyword_FTBFS resolution_fixed type_bug | by pabs

It seems that x86-specific code was added to the exception handler in 3.1, all the Debian 3.1 builds failed with the same error on non-x86 platforms:

https://buildd.debian.org/status/package.php?p=warzone2100

g++ -DHAVE_CONFIG_H -I. -I../..  -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/SDL   -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DNDEBUG -DWZ_DATADIR="\"/usr/share/games/warzone2100\"" -DLOCALEDIR="\"/usr/share/locale\"" -I../.. -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtScript   -D_FORTIFY_SOURCE=2 -g -Wno-enum-compare -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wcast-align -Wwrite-strings -Wpointer-arith -Wno-format-security -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtScript   -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -fstack-protector -c -o exceptionhandler.o exceptionhandler.cpp
exceptionhandler.cpp: In function 'bool gdbExtendedBacktrace(int, const ucontext_t*)':
exceptionhandler.cpp:500:48: error: 'const mcontext_t' has no member named 'gregs'
exceptionhandler.cpp:500:54: error: 'REG_EBP' was not declared in this scope
exceptionhandler.cpp:512:56: error: 'const mcontext_t' has no member named 'gregs'
exceptionhandler.cpp:512:62: error: 'REG_EIP' was not declared in this scope
make[4]: *** [exceptionhandler.o] Error 1

It appears that this commit is responsible for breaking this, it assumes x86 registers are present:

https://developer.wz2100.net/changeset/e7d17ecda05515f4bfc9b95ebc9f0fbcaabf45b2

Issue migrated from trac:3558 at 2022-04-16 09:54:11 -0700
@wzdev-ci
Copy link
Contributor Author

Safety0ff uploaded file 0001-Attempt-to-fix-exception-handler-ifdefs-for-non-x86-.patch (1.7 KiB)

@wzdev-ci
Copy link
Contributor Author

pabs commented

I've uploaded a version with the patch, once it reaches the buildds we will be able to tell if it builds.

@wzdev-ci
Copy link
Contributor Author

pabs commented

Looks like this patch works, thanks.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 5, 2012

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 5, 2012

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 5, 2012

Cyp commented

Closing as fixed, since the patch 6c6180495cc791afe9f818b7070f8a6bc3b13fae was reported to work.

@wzdev-ci wzdev-ci closed this as completed Sep 5, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: other normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci