Modify ↓

Ticket #36 (closed patch (an actual patch, not a request for one): fixed)

Opened 3 years ago

Last modified 21 months ago

modify debug statements to add info on where the file came from.

Reported by: Buginator Owned by:
Priority: normal Milestone:
Component: other Version: git/master
Keywords: Cc:
Blocked By: Blocking:
Operating System: All/Non-Specific

Description

I mean it helps in figuring out just what file physfs is reading from. It just retrieves the real directory it is using for the file in question.

Attachments

RealDirINFO.patch​ (2.8 KB) - added by Buginator 3 years ago.
RealDirINFO2a.patch​ (9.8 KB) - added by Buginator 3 years ago.

Change History

Changed 3 years ago by Buginator

comment:1 Changed 3 years ago by Giel

Looks good to me except for one thing: whitespace, or lack thereof:

Please change "[directory: %s]%s" to "[directory: %s] %s"

Other than that it's entirely fine with me.

comment:2 Changed 3 years ago by Giel

  • Milestone set to 2.2

Changed 3 years ago by Buginator

comment:3 Changed 3 years ago by Buginator

Actually, this should be in trunk & 2.1 branch.

Trying to locate *why* it crashes for some people, and this should at least tell us more information on which (real) directory it is trying to read from.

Perhaps we have a search path issue of some sort?

comment:4 Changed 3 years ago by anonymous

  • Status changed from new to closed
  • Resolution set to fixed

comment:5 Changed 21 months ago by Buginator

  • Milestone 2.2 deleted

Milestone 2.2 deleted

View ↑

Add a comment

Provide an email address (will not be publicly visible) in the Author field or ​register an account (uses your ​forum account).

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.