NoQ edited the issue description

NoQ commented

Ok, i'd better not do multiple water colors by now, need to think a bit more, maybe next time.

NoQ edited the issue description

NoQ changed _comment0 which not transferred by tractive

NoQ changed _comment1 which not transferred by tractive

NoQ commented

This last version of the patch extends the one posted earlier by including the following extra changes:

• fix that allows using multiple seabed and cliff textures, relying on tile types rather than on ground type names
• fix for the "water climbing cliffs" trouble observed on many maps, water is outlined exactly now and never intersects with cliffs
• separation of rocky mountains light snow cliffs from rocky mountains heavy snow cliffs into different ground types, necessary as long as all sorts of cliffs are now rendered exactly, so that not to have too much snow cliffs

NoQ commented

In the v5 patch, rocky mountains looks changes considerably due to improved cliff rendering. I suggest, in addition to this patch, re-using the now-unused old rocky mountains gravel texture as page-110-light-snowcliff-rockies.png for r_snowcliff in tertliesc3hwGtype.txt (also needs to be added to vidmem3.wrf in campaign and skirmish). This makes snowcliffs a bit lighter than regular cliffs, not too light as they are in v5 where i use gravel snow texture for this, and i like how it looks on most of the maps: close to what we have now, but even better.

NoQ uploaded file extended-tilesets-final.patch (14.6 KiB)

NoQ uploaded file page-110-light-snowcliff-rockies.png (562.0 KiB)

Just in case somebody doesn't have it

NoQ changed _comment0 which not transferred by tractive

NoQ commented

In the final version i included the change in the previous commit and made one more change in ground voting: now in a case of equal number of votes a tile with smaller ground type is prioritized, instead of the first encountered one. This puts snow cliffs pretty much back to normal, right now i don't see any regressions with this patch compared to the base game, hence "final".

Note: this also makes terrain more deterministic and symmetric, allows more accurate map making.

NoQ commented

#3621 needs to be resolved before this patch is applied, and rocky ground types need to be carefully merged, prioritizing changes from this patch compared to the tileset before the patch in #3621.

Per commented

Some of the changes here look obviously correct.

Where does the new tile page come from?

Can you put the new tileset support in its own, separate patch?

NoQ commented

The new tile is the one previously used for rocky gravel, until substituted by the new tile specially made by Mangust for 3.1_beta11 (merged together with mysteryem's new sand and Jorzi's cliff decals), so now it's unused, and it's not really new.

NoQ commented

Done with splitting out the bugfix part of the patch.

https://github.com/haoNoQ/warzone2100/commit/41d2df699d0394d589e1ba0c321133c404209e47 water fix

https://github.com/haoNoQ/warzone2100/commit/9b03f8d48aa1bc10c58d7e81c7d70599c06d5b77 ground fix

Per changed status from new to closed

Per changed resolution from `` to fixed