cybersphinx uploaded file warzone2100.gdmp-ibMhTT (42.3 KiB)

vexed commented

Odd, it is working for me in bugfixes.

eisnerd commented

I could confirm that yesterdays 3.1 branch crashes when trying to save after writing 8 bytes to .gam file

dak180 changed _comment0 which not transferred by tractive

tnmurphy@... commented

This seems to relate to the use of std::string mapFileName in the NETPLAY struct. I get a crash in the copy constructor unless I define a non-inline copy constructor but then I get a crash in the destructor for the old string - didn't try making that non-inline too.

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff44ed6c3 in ?? () from /usr/lib64/libstdc++.so.6
(gdb) bt
#0  0x00007ffff44ed6c3 in ?? () from /usr/lib64/libstdc++.so.6
#1  0x00007ffff44eeaf6 in std::string::assign(std::string const&) () from /usr/lib64/libstdc++.so.6
#2  0x000000000059065e in NETPLAY::operator= (this=0x7fffffff56b0) at ../lib/netplay/netplay.h:265
#3  0x0000000000573091 in writeGameFile (fileName=0x7fffffffb820 "savegames/skirmish/crsh.gam", saveType=4) at game.cpp:3901

What fixes it for me is to use a C string. I will attach this in a patch file

tnmurphy@... uploaded file use_cstring_for_mapfilename.patch (1.7 KiB)

patch to fix skirmish game save in head.

Per commented

Related bug #3636

Per Inge Mathisen changed status from new to closed

Per Inge Mathisen changed resolution from `` to fixed

Per Inge Mathisen commented

Do not use std::string in a memory structure that is memset().
Patch by tnmurphy, closes #3620

• Changeset: [/changeset/fdb1c0b52153d3368ae79e8f0befdd2744b43692 fdb1c0b52153d3368ae79e8f0befdd2744b43692]
• URL: Warzone2100/warzone2100@fdb1c0b

Per Inge Mathisen commented

Do not use std::string in a memory structure that is memset().
Patch by tnmurphy, closes #3620

• Changeset: [/changeset/fdb1c0b52153d3368ae79e8f0befdd2744b43692 fdb1c0b52153d3368ae79e8f0befdd2744b43692]
• URL: Warzone2100/warzone2100@fdb1c0b