Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

[src/game.cpp:3762]: (error) Using 'memset' on struct that contains a 'std::string' #3636

Closed
wzdev-ci opened this issue Jul 28, 2012 · 3 comments
Closed

[src/game.cpp:3762]: (error) Using 'memset' on struct that contains a 'std::string' #3636

wzdev-ci opened this issue Jul 28, 2012 · 3 comments
Labels
closed component: Engine: Resource Management normal
Milestone
3.1

Comments

@wzdev-ci
Copy link
Contributor

keyword_savegame resolution_fixed type_bug | by Per

It is actually using memset on a class (Sha256), used from struct MULTIPLAYERGAME. I think this can cause memory corruption. Not sure how to fix it, though.

We could 1) rewrite Sha256 to be C-code, or 2) remove the memset and make sure every access to SAVE_GAME does not rely on the uninitialized values, or 3) rewrite the remaining savegame code. Any other options?

Issue migrated from trac:3636 at 2022-04-16 09:59:15 -0700
@wzdev-ci
Copy link
Contributor Author

Per commented

Related bug #3620

@wzdev-ci
Copy link
Contributor Author

Per changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Per changed resolution from `` to fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: Resource Management normal
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
1 participant
@wzdev-ci