Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Cannot host multiplayer #3651

Closed
wzdev-ci opened this issue Aug 7, 2012 · 7 comments
Closed

Cannot host multiplayer #3651

wzdev-ci opened this issue Aug 7, 2012 · 7 comments
Labels
blocker closed component: other
Milestone
3.1

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Aug 7, 2012

keyword_aaargh keyword_eeek keyword_possibly_broken_rc1 resolution_closed type_bug | by Cyp

Noone tested if multiplayer works, in the last month or so..?

"needs updated server code" — and is there updated server code?

329572779ae2e383b6bd668078ee4ecffe173dc4 is the first bad commit
commit 329572779ae2e383b6bd668078ee4ecffe173dc4
Date:   Sat Jan 21 22:12:25 2012 -0400

    Add last part of net patch (needs updated server code).

:040000 040000 c3419a5e46049e135c45418da285a859e18448ed d41c7494f77b08ebbcdf2f33187f08bccb7239ee M      lib
:040000 040000 0ad7d407e6c490279263108a303767aa3b3f616f 8e8fbb390c6842efc20ba4100b67aceaba562d89 M      src

Issue migrated from trac:3651 at 2022-04-16 10:33:12 -0700
@wzdev-ci
Copy link
Contributor Author

vexed changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

vexed changed resolution from `` to closed

@wzdev-ci
Copy link
Contributor Author

vexed commented

Postponed changes.

@wzdev-ci
Copy link
Contributor Author

Cyp commented

Note that rc1 multiplayer seemed to somehow have retroactively been fixed without reverting, by someone messing with the lobby. So maybe reverting wasn't needed.

P.S. Was the revert commit e90f7761685a51807af1f62ed717c03bb950373f “Revert "Fix reported [-Werror=format] issue."” intentional? As far as I can tell, it might fix stuff on some platforms, and break stuff on none.

@wzdev-ci
Copy link
Contributor Author

Cyp commented

Gah, today rc1 seems to not be working again... Worked last night.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 11, 2012 •
edited

dak180 commented

Replying to Warzone2100/old-trac-import#3651 (comment:1):

Postponed changes.

You do realize that RC 1 has already been tagged, built and more or less released with these changes, right?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 11, 2012 •
edited

vexed commented

Replying to Warzone2100/old-trac-import#3651 (comment:2):

Note that rc1 multiplayer seemed to somehow have retroactively been fixed without reverting, by someone messing with the lobby. So maybe reverting wasn't needed.

Unfortunately, I had no way of testing, since I couldn't build, and I figured why delay things more if that is the only issue.

P.S. Was the revert commit e90f7761685a51807af1f62ed717c03bb950373f “Revert "Fix reported [-Werror=format] issue."” intentional? As far as I can tell, it might fix stuff on some platforms, and break stuff on none.

The commit e90f7761685a51807af1f62ed717c03bb950373f fixed the issue in the first patch, so without doing a revert, it would be a conflict.

Replying to Warzone2100/old-trac-import#3651 (comment:4):

Replying to Warzone2100/old-trac-import#3651 (comment:1):

Postponed changes.

You do realize that RC 1 has already been tagged, built and more or less released with these changes, right?

There was no release announcement, so it wasn't really released. It was just a figment of someones imagination.
RC 1a sounds much better! (It is also odd that about a month went by since that patch and the tag, and nobody bothered to host a game--I know it worked before)

Since RL obligations are in the way of getting to the bottom of what is going on, it just made more sense to revert it, and push it out the door.
3.2 will be the new target for the improvements.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocker closed component: other
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
1 participant
@wzdev-ci