Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

currentBuildPts: conversion to SDWORD #3685

Closed
wzdev-ci opened this issue Aug 25, 2012 · 7 comments
Closed

currentBuildPts: conversion to SDWORD #3685

wzdev-ci opened this issue Aug 25, 2012 · 7 comments
Labels
closed component: Engine: other normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

keyword_currentBuildPts resolution_fixed type_patch (an actual patch, not a request for one) | by Kreuvf

Since our mod has build points > 32767 when trying to build such structures weird behaviour is the result: the building process starts and when exceeding currentBuildPts (overflow) the progress bar becomes very long (see screenshot) for a split second and afterwards the structure starts at 0 again. It even needs to gather new energy.

The patch adds two "D" in whole to make currentBuildPts SDWORD and to change one cast from (SWORD) to (SDWORD). Tested and playable. Interestingly in savegames currentBuildPts was/is saved as SDWORD (if I understand correctly). Netplay was not tested. Patch based on 3.1 RC1. Since I cannot select it in the "Version" field I used 3.1 RC 2. Please add version "other" also. No unwanted effects observed with this patch.

Issue migrated from trac:3685 at 2022-04-16 10:35:31 -0700
@wzdev-ci
Copy link
Contributor Author

Kreuvf uploaded file 20120825_currentBuildPts_SDWORD.patch (1.4 KiB)

Patch: Change data type of currentBuildPts from SWORD to SDWORD

@wzdev-ci
Copy link
Contributor Author

Kreuvf uploaded file wz2100-20120819_160931-Sk-Rush.png (450.1 KiB)

currentBuildPts overflow effect: very long progress bar
wz2100-20120819_160931-Sk-Rush.png

@wzdev-ci
Copy link
Contributor Author

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Cyp commented

Change data type of currentBuildPts from SWORD to int32_t, by Kreuvf.

Based on patch by Kreuvf.

Avoids currentBuildPts overflow effect: very long progress bar.

Fixes #3685.

  • Changeset: [/changeset/5b3163b9433604a470a9b4b3758081e2cdbb3755 5b3163b9433604a470a9b4b3758081e2cdbb3755]
  • URL: [5]b3163b9433604a470a9b4b3758081e2cdbb3755

@wzdev-ci
Copy link
Contributor Author

Cyp commented

Change data type of currentBuildPts from SWORD to int32_t, by Kreuvf.

Based on patch by Kreuvf.

Avoids currentBuildPts overflow effect: very long progress bar.

Fixes #3685.

  • Changeset: [/changeset/5b3163b9433604a470a9b4b3758081e2cdbb3755 5b3163b9433604a470a9b4b3758081e2cdbb3755]
  • URL: [5]b3163b9433604a470a9b4b3758081e2cdbb3755

1 similar comment
@wzdev-ci
Copy link
Contributor Author

Cyp commented

Change data type of currentBuildPts from SWORD to int32_t, by Kreuvf.

Based on patch by Kreuvf.

Avoids currentBuildPts overflow effect: very long progress bar.

Fixes #3685.

  • Changeset: [/changeset/5b3163b9433604a470a9b4b3758081e2cdbb3755 5b3163b9433604a470a9b4b3758081e2cdbb3755]
  • URL: [5]b3163b9433604a470a9b4b3758081e2cdbb3755

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: other normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci