NoQ edited the issue description

NoQ commented

By the way, here's a piece of code i use to list all physfs contents together with the files' real dirs.

void printRecursive(char *path) {
	char **rc = PHYSFS_enumerateFiles(path);
	char **j;
	char str[512];
	for (j = rc; *j != NULL; j++) {
		sprintf(str,"%s%s",path,*j);
		if (PHYSFS_isDirectory(str)) {
			sprintf(str,"%s/",str);
			printRecursive(str);
		} else {
			debug(LOG_WZ, "        %s from %s.\n", str, PHYSFS_getRealDir(str));
		}
	}
	PHYSFS_freeList(rc);
}

dak180 edited the issue description

vexed commented

Another library that needs to be whacked via some autohell love.

This is fixed (I guess?) in:
http://hg.icculus.org/icculus/physfs/rev/882cdbd7d0a3

Care to try it ? I know you are itching to try hg (Mercurial) :)

Cyp commented

Forgot to post this earlier:

Reproducible on Gentoo, the MC AI works with 2.0.1 but not 2.0.2-[1].

So it's either a bug in PhysFS, or some weird incomprensible misuse of PhysFS, since the PhysFS version oughtn't really be affecting whether a file exists.

(Based on above comment, I'm guessing it could be the former.)

Cyp changed keywords from `` to broken_upstream upstream_patch_exists i_am_using_random_keywords

Cyp commented

Don't know what http://hg.icculus.org/icculus/physfs/rev/882cdbd7d0a3 does, but the MC AI seemed to work with 2.0.2-[1], once I manually applies that patch (in a text editor).

I wasn't itching to try Hg, so I used nano instead.

Cyp commented

Warn on apparently buggy PhysFS version 2.0.2.

Refs #3700.

• Changeset: [/changeset/408be743f017cce1519cd955767abf0e697ab7f7 408be743f017cce1519cd955767abf0e697ab7f7]
• URL: [408]be743f017cce1519cd955767abf0e697ab7f7

dak180 commented

Patch PhysFS in the mac build until there is a new release.

Refs #3700.

• Changeset: [/changeset/a05e8c980bc42fa66ed1b81ae40793645df8efbf a05e8c980bc42fa66ed1b81ae40793645df8efbf]
• URL: Warzone2100/warzone2100@a05e8c9

Cyp commented

Think #3555, #3585, #3587, #3595, #3673, #3680, #3687 are duplicates of this bug.

NoQ commented

Reported to affect windows: http://forums.wz2100.net/viewtopic.php?f=49&t=9493&start=255#p111983

vexed commented

PhysicsFS 2.0.3 is now available.

This is a stable, bug-fix release. As we are still source and binary compatible, all users of any previous version--be it 1.0 or 2.0--are encouraged to upgrade. New features are being added to the 2.1 branch, which is not part of this release.

You can grab it here...

 http://icculus.org/physfs/downloads/physfs-2.0.3.tar.bz2

...or from Mercurial with this command...

 hg clone -u release-2.0.3 http://hg.icculus.org/icculus/physfs

...or just stare at the webview here...

 http://hg.icculus.org/icculus/physfs/file/release-2.0.3

Notable changes in this release:

• Source code now packaged in a .tar.bz2 instead of .tar.gz.
• Fixed "make docs" for out-of-tree builds.
• No longer builds annoying wxWidgets test program by default.
• Fixed logic bug in UTF-8 string processing.
• Fixed infinite loop on some .zip files with symlinks.
• Enabled CD-ROM support on Haiku OS.
• Fixed Win64 support.
• Fixed OpenBSD support.
• Fixed building of readline support in test program.
• Fixed .zip archiver losing files in some cases.
• Corrected copyright dates in license.
• Other minor tweaks and fixes.

Thanks to those that sent in patches! If we're lucky, this will be the last 2.0 branch release, and we'll start pushing 2.1 development branch releases soon.

dak180 commented

Update PhysFS to 2.0.3.

Refs #3700.

• Changeset: [/changeset/647f5ed23682f650fad1f23ced693a24258ac7dc 647f5ed23682f650fad1f23ced693a24258ac7dc]
• URL: [647]f5ed23682f650fad1f23ced693a24258ac7dc

vexed changed status from new to closed

vexed changed resolution from `` to external

vexed commented

OK, everyone upgrade to 2.0.3.

Closing ticket.