Per changed blocking which not transferred by tractive

Per changed blockedby which not transferred by tractive

Per commented

Please see http://developer.wz2100.net/wiki/CommitGuidelines on how to squash all related changes into one single commit.

Per commented

Oh, and Nexus AI is broken (assert fails) in current trunk due to previous batch of ini commits. Maybe fix that first? :)

Per commented

Nexus AI fixed in db442bc143f701e5af4d96704c2cde4c095ce0e4. I expect conflicts with your new work, though. Please use the new utility function to prevent new bugs like the above.

felipe commented

In the patch I just sent all that problems were fixed.
Not all the stats have the NULLxxxx entry, that function could not be used always.
The problem you mention is not solved.

Take a look at my patch which I meticulously checked and tested.

Per commented

Post bug fixes always separate from features!

Not sure what you mean with all problems fixed but not solved...

I'm on IRC now if you want to discuss.

felipe uploaded file diff (341.9 KiB)

cumulative patch

vexed commented

Isn't this the same as #3795 ?

Per changed status from new to closed

Per changed resolution from `` to fixed

Per commented

Done.

vexed changed status from closed to reopened

vexed changed resolution from fixed to ``

vexed changed priority from normal to blocker

vexed changed _comment0 which not transferred by tractive

vexed commented

I don't understand why the same functionality was removed from the original version.

See 376c8c65fcc33eb31541a971e6c8b7e9c2013f18 specifically, the changes done in src/data.cpp

The other issue is the memory access bugs.

See #3821

Per commented

I don't understand the question. The memory access bugs have their own ticket, so no reason to reopen this one.

vexed commented

I don't understand why the same functionality was removed from the original version.

See 376c8c65fcc33eb31541a971e6c8b7e9c2013f18 specifically, the changes done in src/data.cpp

Replying to Warzone2100/old-trac-import#3794 (comment:10):

The hash routines are removed.
That is a change in functionality, and can cause numerous issues in MP games.

Per commented

We need a way to send hashes for files that are not loaded as buffers into the resource system. Preferably cached so that we do not have to load such files for hashing, then another time to read its data, all the time.

Per changed title from Branch new1 in my repo is ready to merge to Missing CRC hash checks for ini files

klasskill commented

ran into this the other day and it was desync city because one guy forgot he changed some stuff for local testing

klasskill commented

still a problem with data not matching!

pastdue changed _comment0 which not transferred by tractive

pastdue commented

Please see: Warzone2100/warzone2100#210

Patch: https://github.com/Warzone2100/warzone2100/pull/210.patch

Help testing (especially cross-platform multiplayer games) is greatly appreciated.

NOTE: Since everyone needs to have this patch applied to play (prior versions obviously don't calculate the hash of the files), the best route for getting widespread testing will probably be to just merge it into the master branch.

pastdue commented

This is now in the master branch.

Various folks on IRC have helped with some cross-platform multiplayer testing.

pastdue changed status from reopened to closed

pastdue changed resolution from `` to fixed