Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Crash in map grid iterator #3894

Closed
wzdev-ci opened this issue Jan 20, 2013 · 15 comments
Closed

Crash in map grid iterator #3894

wzdev-ci opened this issue Jan 20, 2013 · 15 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by NoQ


It seems to be the moment when an incendiary (phosphor, namely) bomb is fired. The crash has happened twice on my machine, but i lost the first dump. I can't reproduce it reliably though.

It's the same crash that we had when testing the incendiary damage modifier patch by crabster, and now i'm sure it's not related to his patch. I didn't have any such crashes on 3.1 (yet).

Mods mentioned in the crash dump below are JS/AI only; i don't think they affect it.


Issue migrated from trac:3894 at 2022-04-16 10:49:34 -0700

@wzdev-ci
Copy link
Contributor Author

NoQ uploaded file warzone2100.gdmp-AjCu6b (24.9 KiB)

@wzdev-ci
Copy link
Contributor Author

NoQ commented


Ah, found the old crash. By the way, had a closer look at the new crash, and it's not really related to the burn damage, yet still looks very similar.

@wzdev-ci
Copy link
Contributor Author

NoQ uploaded file warzone2100.gdmp-23aeac (27.5 KiB)

@wzdev-ci
Copy link
Contributor Author

NoQ uploaded file warzone2100.gdmp-VMb6yA (25.8 KiB)

Yet another similar dump.

@wzdev-ci
Copy link
Contributor Author

Per changed title from A certain crash in incendiary damage code. to Crash in map grid iterator

@wzdev-ci
Copy link
Contributor Author

Per commented


Several crash dumps in this ticket, all pointing to gridIterate () at mapgrid.h:57.

@wzdev-ci
Copy link
Contributor Author

Reg312 commented


Tried to reproduce this crash on my windows build, but unsuccessful

@wzdev-ci
Copy link
Contributor Author

NoQ commented


Since nobody can reproduce that, i wonder if it's related to the fact that i now use js_enumRange() in my scripts, which also uses gridIterate().

@wzdev-ci
Copy link
Contributor Author

Cyp changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Cyp commented


Note the nearby comment »// Detect (by crashing in a reproducible way) if calling gridIterate() again before gridStartIterate().«, which may be relevant.

Doing something like

gridStartIterate(something)
while(gridIterate())
{
    gridStartIterate(somethingElse)
    while(gridIterate())
    {
        doSomething();
    }
}

will crash there, since the inner loop clobbers the outer loop.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 8, 2013

NoQ commented


Is there any way for me to gather more information? Probably somebody could provide a patch that would expose more relevant debug data?

Cause i'm able to reproduce it very often, but absolutely unreliably.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 9, 2013

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 9, 2013

Cyp changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Feb 9, 2013

Cyp commented


"Auto"closing ticket. Don't know where the issue was, but should probably be fixed now, since there's nowhere for it to hide, now.

commit 5c7788784b653cae0fdf80ad687c4aec2c58a3f5
Author: Cyp
Date: Sat Feb 9 12:33:00 2013 +0100

Change gridStartIterate interface to safely allow recursive calls.

Probably fixes #3894.

@wzdev-ci wzdev-ci closed this as completed Feb 9, 2013
@wzdev-ci
Copy link
Contributor Author

NoQ commented


Just wanted to mention that crashes seem to have actually gone, thanks all again (:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant