Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Today's JS bug investigations #3896

Closed
wzdev-ci opened this issue Jan 21, 2013 · 3 comments
Closed

Today's JS bug investigations #3896

wzdev-ci opened this issue Jan 21, 2013 · 3 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by NoQ


Even though cyborg engineer's .droidType JS property is equal to DROID_CONSTRUCT, cyborg engineers don't get enumerated by enumDroid(me, DROID_CONSTRUCT), because enumDroid only considers C-style droid types (so it needs to be called with DROID_CYBORG_CONSTRUCT instead). Same applies to DROID_CYBORG_REPAIR, i think.

Range parameter in enumRange() needs to be converted to world coordinates or something like that.

JS allows placing non-VTOL weapons on VTOLs in buildDroid().

droid.propulsion property returns a body stat name with the same number instead of a propulsion stat name (typo in convDroid()).


Issue migrated from trac:3896 at 2022-04-16 10:49:43 -0700

@wzdev-ci
Copy link
Contributor Author

NoQ commented


Three issues with getWeaponInfo():

.class property should be renamed, since "class" is a reserved keyword.

getWeaponInfo() should return something from time to time.

Probably add some check to make sure psStats in this function is valid, so that the game didn't crash in getStatName but provide a JS assert fail instead.

@wzdev-ci
Copy link
Contributor Author

Per changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Per changed resolution from `` to fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant