Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Unreliable method for player "nice" leaving. #3897

Open
wzdev-ci opened this issue Jan 21, 2013 · 5 comments
Open

Unreliable method for player "nice" leaving. #3897

wzdev-ci opened this issue Jan 21, 2013 · 5 comments
Labels
component: Engine: Networking new normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

type_bug | by bendib

Since back in the early betas, the netcode has used the "drop" call for generic, supposedly nice, player quitting. This does not always work and causes hangs when a player quits often. If the NET_PLAYER_LEAVING signal actually got sent/received, these incidents would drop by many magnitudes.

Issue migrated from trac:3897 at 2022-04-16 10:49:46 -0700
@wzdev-ci
Copy link
Contributor Author

bendib uploaded file netplayerleaving.patch (2.3 KiB)

pseudo-patch that remedies the symptoms for clients, but not hosts.

@wzdev-ci
Copy link
Contributor Author

bendib changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

bendib changed _comment1 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

bendib changed _comment2 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

bendib commented

Added a patch (for master) that is functionally identical to the temporary solution used by Legacy. This works because NETshutdown() slams the door properly if you are a client.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: Engine: Networking new normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci