Buginator uploaded file reworkMenu.patch (2.9 KiB)

Buginator commented

ack! the layout sucks.

 This is the change:
 Start menu:
 ------------
 "Single Player / Skirmish Game"
 "Multi Player Game"
 "Tutorial"
 "Options"
 "Quit Game"
 -------------
 "Single Player / Skirmish Game" menu:
 "New Campaign"
 "Start Skirmish Game"
 "Load Game"
 -------------
 "Multi Player Game" menu:
 "Host Game"
 "Join Game"
 -------------

 All the rest is exact same.

 Would like this to go into 2.1 + trunk

Giel commented

Replying to Warzone2100/old-trac-import#41 (comment:1):

ack! the layout sucks.

Might want to try the "preview" button. I know Gna! doesn't have one, but Trac does ;-)

Might want to change _("Single Player / Skirmish Game") to _("Campaign or Skirmish Game") (also, I prefer "or" instead of "/"). Other than that the change looks good to me.

Kreuvf commented

What's with Fastplay? And why did you not reply@Gna!?

Giel commented

Replying to Warzone2100/old-trac-import#41 (comment:3):

And why did you not reply@Gna!?

Because we're sort-of (unofficially) moving more to Trac as project tracker.

Kreuvf commented

Then I am for announcing it officially: ML, IRC (#warzone2100), forums, readme... well, everywhere. Unofficial things may give an impression of "everybody does what he/she likes" and I highly doubt that this is of any good for the project ;)

Giel commented

Replying to Warzone2100/old-trac-import#41 (comment:5):

Then I am for announcing it officially: ML, IRC (#warzone2100), forums, readme... well, everywhere.

Announce what officially? Trac being the issue tracker?

Unofficial things may give an impression of "everybody does what he/she likes" and I highly doubt that this is of any good for the project ;)

And making things "official" before having had a decent chance to experiment with them might just make a worse impression about this (or any, for that matter) project... Honestly, I'd rather have people to have the impression of "everybody does what he/she likes".

Buginator commented

I thought we were just checking to see how well Trac responds, and just how much better it is than GNA's bug/patch trackers.

If all goes well in these tests, I am all for using Trac instead of GNA. The only other issue has to do with backups, and communication with the ML.

Giel commented

Replying to Warzone2100/old-trac-import#41 (comment:7):

The only other issue has to do with backups, and communication with the ML.

Backups should be easy enough to set up. Just invoking

trac-admin /path/to/trac/environment hotcopy /path/to/store/backup/at

will do the trick. So doing that in a script that stuffs "/path/to/store/backup/at" in a tarball and dumps it at some publicly available place would do the trick.

As for communication with the ML. What do you mean by that? Notifying the ML upon creation of new tickets? Because that's already done, due to Kamaze applying the patch from TracTicket:6613

Zi-Chan commented

Why Single Player and Skirmish together in one menu point name? It looks too long and since you can then choose between Campaign and Skirmish, the menu point should only be called "Single Player", nothing more.

This and some more ideas at my forums topic:
http://forums.wz2100.net/viewtopic.php?f=8&t=1748&p=19828#p19828

Zi-Chan commented

And the "Game" after "Single Player" and "Multi Player" isn't needed, since it should be clear, that this is a Game and there must be a Menu Point for starting it. =P

Giel commented

Replying to Warzone2100/old-trac-import#41 (comment:9):

Why Single Player and Skirmish together in one menu point name? It looks too long and since you can then choose between Campaign and Skirmish, the menu point should only be called "Single Player", nothing more.

We already decided on the mailing list to go with plain "Single Player" instead. That discussion might have been better placed here...

Anyway, this is the mailing list thread: https://mail.gna.org/public/warzone-dev/2008-08/msg00116.html

Buginator uploaded file NewMenuLayout2_1.patch (2.9 KiB)

(final) 2.1

Buginator uploaded file NewMenuLayouttrunk.patch (3.0 KiB)

final (trunk)

Buginator commented

This should be everything everyone requested.

Giel commented

Replying to Warzone2100/old-trac-import#41 (comment:12):

This should be everything everyone requested.

I suggest that you commit the patch to trunk and back port it from trunk to 2.1, that'll make it more obvious that you're not duplicating changes.

Aside from that, at the risk of being annoying, please leave an empty line before and after the "case FRONTEND_SKIRMISH:" code block (e.g. take a look at the other code blocks there, except for "case FRONTEND_LOADCAM3:", ignore that one).

Buginator changed status from new to closed

Buginator changed resolution from `` to fixed

Giel commented

This patch was committed in [5888] and backported to 2.1 in [5889]