NoQ uploaded file 0001-Move-random-oil-drum-placement-to-rules-js.patch (7.3 KiB)

Per changed blocking which not transferred by tractive

Per changed blockedby which not transferred by tractive

Per commented

I really like the idea of moving drum placement into scripts.

Perhaps add a check that drums are never placed inside any player's starting base?

(And maybe oil drums should always spawn near an oil resource? Just an idea that popped out of my head.)

Please add a comment to large numbers like 600000 saying what it means in reasonable units like minutes. They are hard to parse for humans otherwise :)

No need to keep unnecessary code.

Might be a good idea to add syncDiv() and syncMod().

NoQ changed _comment0 which not transferred by tractive

NoQ commented

600000
Hmm. As homework, I'd try to implement exponential distribution for this value. Otherwise people would remember to look for drums every 10 minutes.

P.S. why do we respawn them at all? That's hardly realistic. The "near oils" idea looks curious though.

Perhaps add a check that drums are never placed inside any player's starting base?

Can do, by increasing radius in enumRange() call. Or maybe add a special check ...

NoQ commented

Or rather geometric distribution.

// generate Geom(1/6) distribution for oil drum respawn delay
for (delay = 0;; ++delay)
{
	if (syncRandom(6) == 0)
	{
		break;
	}
}
// amounts to 10 minutes average respawn time
queue("placeOilDrum", delay * 120000);

Then for the real trouble: propulsionCanReach() aka fpathCheck() sometimes fails. Steps to reproduce: start a game on Sk-Highground and execute propulsionCanReach("wheeled01", 18, 31, 11, 31) in jsdebug. It prints true, which is wrong because (11, 31) is a cliff tile.

vexed commented

The only reason we respawn them is, it was like that since day 1, with the change being that VTOL's can't pick them up like they did before (I think--I don't recall exactly)

Not sure I follow the reason to move it to JS, I guess it could be just as easy to turn on / off this feature via a script command, then you can place whatever feature you want where ever you want.

As you have noticed, we still have lots of issues with the pathing code and associated routines.

NoQ commented

A JS function for disabling (or enabling) drum spawning is enough of course, it just simply looks ugly, and it won't solve it when somebody would anyway want to make a custom respawn method.

I am still to figure out what really needs to be done to fpathCheck(). Maybe just add a JS function to get tile type of tiles (such as ground/water/cliff/road/whatever)? This ticket is a good example of a lightweight use case for such function.

NoQ commented

Well, i guess i really shouldn't touch fpathCheck(); it just checks for something different from what i expected.

So i think i'd add a function to check terrain type. I add JS constants for only TER_WATER and TER_CLIFFFACE and say that everything else is ground; this is enough for simple stuff, and this way we can later extend API to either allow distinguishing between sand and road, or disallow it if we eventually deprecate speed differences between them.

Attaching a working version with two patches:

0001-qtscript-Add-terrainType-x-y-to-check-passability-of.patch
0002-Move-random-oil-drum-placement-to-rules.js.patch

NoQ uploaded file 0001-qtscript-Add-terrainType-x-y-to-check-passability-of.patch (2.8 KiB)

NoQ uploaded file 0002-Move-random-oil-drum-placement-to-rules-js.patch (7.7 KiB)

second version, requires qtscript patch

Per commented

Looks good to me.

NoQ changed status from new to closed

NoQ changed resolution from `` to fixed

NoQ commented

Pushed :)

vexed commented

in d289598813fbf1f865faebdd79de6492c1967262

(use closes/fixes #4143 in commit message...) Makes book keeping easier :)

BTW, moving this to JS also opens the door to more abuse.

Per commented

I don't think this allows for abuse. If anyone changes the algorithm, then this will create a desync.

NoQ commented

Even without unhardcoding, a cheater could implement his own oil drum spawner in rules.js, along with the hardcoded oil drum spawner.

vexed commented

See forum thread for more about this.

crab_ commented

Replying to Warzone2100/old-trac-import#4143 (comment:12):

See forum thread for more about this.

Please can you give me link to that forum thread.