Ginger88895 uploaded file snapshot1.png (721.5 KiB)

Ginger88895 commented

Sorry I forgot to provide some information.
Version: git/master (nightly)
Component: stats/balancing
Operating System: Linux 64-bit

Roland uploaded file #4179.patch (0.6 KiB)

Fixing Patch

Roland commented

There was an integer arithmetic overflow while multiplying with WEAPON_TIME.
I've attached a patch that fixes that.

vexed changed status from new to closed

vexed changed owner from `` to vexed

vexed changed resolution from `` to fixed

vexed committed [42]

In Warzone2100/warzone2100@42cf3af:

#CommitTicketReference repository="" revision="42cf3af169466aa3ed7aa28192d8fcd9c4f8479d"
Fix horrible formatting, and fix types to be what they were before.
(prevents unwanted overflow behavior --don't use signed types if we don't know for sure that they will not cause undesired behavior)
For example, range should never have a negative value, and on a overflow, it would now have a negative value.

refs: 545832358b570e340e1b9fd0b689b9c9693bcc7d
closes #4301
fixes #4179