Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

transporter cleanup / patch #4246

Closed
wzdev-ci opened this issue Nov 11, 2014 · 12 comments
Closed

transporter cleanup / patch #4246

wzdev-ci opened this issue Nov 11, 2014 · 12 comments
Labels
closed component: other normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by vexed

Cleaning up all these things to make it less error prone.
No logic should have changed at all, if it did, then it is an error.

The transporter fix patch obviously needs the other patch first.

Would be nice to gets some extra set of eyes on this, in case I missed something.

Issue migrated from trac:4246 at 2022-04-16 11:46:41 -0700
@wzdev-ci
Copy link
Contributor Author

vexed uploaded file 0001-Cleanup-code.patch (57.8 KiB)

for master

@wzdev-ci
Copy link
Contributor Author

vexed uploaded file 0001-Transporter-cleanup.-bugfixes-3.1.patch (65.7 KiB)

bugfixes/3.1

@wzdev-ci
Copy link
Contributor Author

vexed uploaded file 0001-Don-t-allow-transporters-to-pick-up-oil-artifacts-ei.patch (1.0 KiB)

needs the other patches applied first.

@wzdev-ci
Copy link
Contributor Author

stiv commented

Amazing how one little func makes the code so much prettier.

Don't see anything obviously wrong a first glance. If it compiles, ship it!

@wzdev-ci
Copy link
Contributor Author

Per commented

Looks good to me.

@wzdev-ci
Copy link
Contributor Author

vexed changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

vexed changed owner from `` to vexed

@wzdev-ci
Copy link
Contributor Author

vexed changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

vexed committed [93]

In Warzone2100/warzone2100@93c18a2:

#CommitTicketReference repository="" revision="93c18a2385f3525b261452d8690730cc9162650f"
Transporter cleanup.
Using isTransporter() instead of psDroid->droidType ## DROID_TRANSPORTER || psDroid->droidType DROID_SUPERTRANSPORTER.

There should be no logic changes in this patch.
closes #4246

@wzdev-ci
Copy link
Contributor Author

vexed commented

In Warzone2100/warzone2100@c36361b:

#CommitTicketReference repository="" revision="c36361bb1e7117e059a607011945b87eec3c9408"
Don't allow transporters to pick up oil/artifacts either.
refs #4246

@wzdev-ci
Copy link
Contributor Author

vexed committed [99]

In Warzone2100/warzone2100@99b8218:

#CommitTicketReference repository="" revision="99b8218a8e0578ed8bb8f8d5c618d070e76e19da"
Fix 'go to Transport' logic.

closes ticket #4339
refs ticket #4246

@wzdev-ci
Copy link
Contributor Author

vexed committed [201]

In Warzone2100/warzone2100@201dc76:

#CommitTicketReference repository="" revision="201dc762786ead3f1096d95f6fb949bc3aacbc3a"
Let's try that again, and this time C&P the correct fix.

Fixes last commit 99b8218a8e0578ed8bb8f8d5c618d070e76e19da

fixes #4339

refs #4246

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: other normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci