Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Fog? #4292

Closed
wzdev-ci opened this issue Apr 5, 2015 · 10 comments
Closed

Fog? #4292

wzdev-ci opened this issue Apr 5, 2015 · 10 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Apr 5, 2015

resolution_closed type_patch (an actual patch, not a request for one) | by NoQ


I don't remember whatever motivation was there for removing it, but it seems easy to bring it back.

The following patch brings back fog, sets its color to values found in the old campaign scripts, and exposes fog color to javascript for day-night stuff.

The only problem is, some models get their alpha-transparency broken. The only case i noticed is the new pine tree models. If anybody fixes that, probably even on the model side(?), maybe it's worth it to re-enable the fog?

If so, please review, as i'm not good with OpenGL stuff (we need something like glClearColor() to change the whole background color around the map, not only gl fog).


Issue migrated from trac:4292 at 2022-04-16 11:50:17 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2015

NoQ uploaded file wz2100-20150405_141717-Fresh-1-01-T1.jpg (648.0 KiB)

wz2100-20150405_141717-Fresh-1-01-T1.jpg

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2015

NoQ uploaded file 0001-qtscript-Allow-changing-the-fog-color.patch (6.1 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2015

NoQ commented


Jorzi's pine trees are free from this glitch because they don't use alpha on the textures! So if we agree to merge those, there's nothing else that blocks this patch(?)

@wzdev-ci
Copy link
Contributor Author

vexed changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

vexed changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

vexed commented


I don't recall the reason for removal, but, glFog() is deprecated these days...
I guess we would need a GLSL solution to get away from fixed pipeline calls.
(Which is the plan I believe.)

@wzdev-ci
Copy link
Contributor Author

NoQ commented


Sounds like an independent task. I'm not adding or removing any glFog() calls, just changing color from black to something else.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed resolution from `` to closed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented


Fog works again and has a function to change the color in the JS API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant