vexed changed _comment0 which not transferred by tractive

vexed commented

Well... Libpng-1.6 is more stringent about checking ICC profiles than previous versions. Since these warnings are more or less meaningless for us (ICC profiles), you can ignore the warning.

Or in other words, not sure it is worth redoing however many pngs just to shutup a meaningless warning for us compared to the bandwidth required to fix the pngs in question.

Perhaps when the Artdev guys finish up their work, we can just replace them all then?

Per commented

It is really annoying, it causes so much scrolling that useful errors are sometimes overlooked.

Quick fix: find data -name *.png -execdir mogrify {} ;

Unless there are objections, I will commit this to bugfixes soon. (Yes, this will cause all PNGs to be uncrushed.)

stiv commented

Yeah,let's do this. A lot graphic apps are starting to recognize color profiles now so it actually matters.

It's worth putting in master also, IMHO.

As for the PNGs being uncrushed, this is good. We use them as texture maps, not for web display.

vexed commented

Actually, no, not yet.

This will be a huge, huge commit.
This can be better solved with ripping out our data, and putting it into its own repo, then using git subtree or submodule to pull it in.
Also, need to wait for the release of 3.1.3 first IMO, since that has blockers.

Cyp <cyp@...> changed status from new to closed

Cyp <cyp@...> changed owner from `` to Cyp <cyp@wz2100.net>

Cyp <cyp@...> changed resolution from `` to fixed

Cyp <cyp@...> committed [0]

In Warzone2100/warzone2100@0fde4c8:

#CommitTicketReference repository="" revision="0fde4c81152463389e906998f4590873d8058eb7"
Fix specific .png files which were causing libpng warnings.

libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: cHRM chunk does not match sRGB

Fixed with mogrify and then (re-)crushed.

Fixes #4320.